Page MenuHomePhabricator

Create client hint mapping rows for CheckUser-worthy events
Open, Needs TriagePublic

Description

In T337944: Implement support for requesting client hint header we added support for setting the Accept-CH header on the following workflows:

  • [web] Special:CreateAccount
  • [web] Special:UserLogin
  • [web] Special:UserLogout
  • [web] Special:PasswordReset
  • [web] Special:EmailUser
  • [web] ?action=history (for rollback)
  • [API] edit handled via postEdit mw.hook (as is non-API editing)

In T258105: Implement storage for User-Agent Client Hints header data we defined database tables to store the data. Currently, editing scenarios write data to these tables (using the postEdit mw.hook).

We need to create record client hint data for:

Related Objects

StatusSubtypeAssignedTask
OpenNone
Resolvedkostajh
OpenNone
OpenFeatureDreamy_Jazz
ResolvedLadsgroup
ResolvedMilimetric
OpenNone
OpenNone
OpenNone
OpenDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedMarostegui
ResolvedPRODUCTION ERRORDreamy_Jazz
ResolvedMarostegui
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
OpenDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedPRODUCTION ERRORpmiazga
OpenNone
ResolvedDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
OpenNone
OpenNone

Event Timeline

We could either mark this task as stalled pending the resolution of T258105: Implement storage for User-Agent Client Hints header data, or, we can start building on top of the WIP patch for DB storage.

Actions which produce a public log entry will need to wait for T324907 to be complete (so that the client hints data can be stored under the log ID).

For events which do not have a log ID or revision ID, they will also need to wait for T324907 to be complete as it will reference a row in cu_private_event.

kostajh changed the task status from Open to Stalled.Aug 22 2023, 10:23 AM

Actions which produce a public log entry will need to wait for T324907 to be complete (so that the client hints data can be stored under the log ID).

For events which do not have a log ID or revision ID, they will also need to wait for T324907 to be complete as it will reference a row in cu_private_event.

Marking as stalled pending T324907: Create separate tables for log events in CheckUser.

Dreamy_Jazz changed the task status from Stalled to Open.Aug 29 2023, 1:11 PM

Progress on this task can start, as we are now writing to the new tables created in T324907 (see T330158).