Unselecting an item in a SelectWidget throws TypeError
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	WMDE-Fisch
	Jul 7 2023, 10:11 AM

Description

Introduced with the latest OOUI Update. Can be reproduced in Advanced-Search on the beta cluster.

Go to the search page with the AdvancedSearch interface
Open the namespace selection by expanding Search in
Open the list of available namespaces by clicking in Add namespaces..
Unselect (Article) by clicking on it

Introduced in https://gerrit.wikimedia.org/r/c/oojs/ui/+/923297 and with the update to OOUI v0.47.3

Uncaught TypeError: state is undefined

setSelected OptionWidget.js:175
unselectItem SelectWidget.js:826

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.47.4	mediawiki/core	master	+43 -39
Revert "Update OOUI to v0.47.3"	mediawiki/core	master	+145 -433
Fix TypeError in OptionWidget	oojs/ui	master	+3 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dduvall	T340245 1.41.0-wmf.17 deployment blockers
		Resolved	BUG REPORT	thiemowmde	T341336 Unselecting an item in a SelectWidget throws TypeError

Event Timeline

WMDE-Fisch created this task.Jul 7 2023, 10:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2023, 10:11 AM

Change 936253 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Fix TypeError in OptionWidget

https://gerrit.wikimedia.org/r/936253

gerritbot added a project: Patch-For-Review.Jul 7 2023, 11:25 AM

thiemowmde claimed this task.Jul 7 2023, 11:26 AM

thiemowmde triaged this task as High priority.

thiemowmde moved this task from Backlog to Doing on the OOUI board.

thiemowmde added a project: WMDE-TechWish-Maintenance-2023.

thiemowmde changed the subtype of this task from "Task" to "Bug Report".

thiemowmde added subscribers: matmarex, thiemowmde.

thiemowmde moved this task from Backlog to Review on the WMDE-TechWish-Maintenance-2023 board.Jul 7 2023, 11:28 AM

thiemowmde added a subscriber: Catrope.

Change 936253 merged by jenkins-bot:

[oojs/ui@master] Fix TypeError in OptionWidget

https://gerrit.wikimedia.org/r/936253

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2023, 1:10 AM

WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Jul 10 2023, 8:04 AM

matmarex added a parent task: T340245: 1.41.0-wmf.17 deployment blockers.Jul 10 2023, 1:21 PM

Change 936696 had a related patch set uploaded (by Bartosz Dziewoński; author: Anne Tomasevich):

[mediawiki/core@master] Revert "Update OOUI to v0.47.3"

https://gerrit.wikimedia.org/r/936696

gerritbot added a project: Patch-For-Review.Jul 10 2023, 1:21 PM

We need to figure out how to fix the OOUI version in MediaWiki. There are three options:

Revert – Proposed by @AnneT/@WMDE-Fisch. It would require tracking down and reverting any patches that already depend on 0.47.3, e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/923603.
Upgrade – It would require making a 0.47.4 release, not sure who can do that.
Hotfix – Copy paste the changes in https://gerrit.wikimedia.org/r/c/oojs/ui/+/936253 into the .js file in MediaWiki. We've done that in the past, e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/923417 but people ribbed me for it. I can do it again though. ;)

@matmarex I'll attempt a new OOUI release now - Volker and Roan are both out, and I've never done one before, but Roan did just update the releasing instructions so let's hope for the best :) I'll post an update here soon...

I support the idea of hot-patching the copy in core. It can really be a single line of code. This one here: https://gerrit.wikimedia.org/r/c/oojs/ui/+/936253/1/src/widgets/SelectWidget.js#826. Unfortunately I'm currently unable to assist this.

Thanks @thiemowmde—I've reviewed the release process and it isn't too difficult, so I will go ahead and submit the patches, but if it ends up not being possible in the time we have we can just backport as a back-up option.

Change 936764 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update OOUI to v0.47.4

https://gerrit.wikimedia.org/r/936764

Change 936764 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.47.4

https://gerrit.wikimedia.org/r/936764

Change 936696 abandoned by Jforrester:

[mediawiki/core@master] Revert "Update OOUI to v0.47.3"

Reason:

We landed v0.47.4 instead.

https://gerrit.wikimedia.org/r/936696

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 5:00 PM