@NNichols do you mean you want the initial contribution and the repeat ones to have the financial type recurring? I assume we can't have endowment recurrings?

Question on the naming, the civi calls these contributions we also call them donations, is there a difference on your end between a gift and a contribution?

@JMando @MSuijkerbuijk_WMF Would there be a benefit for either of you two to differentiate between the first recurring gift and all subsequent gifts? For example, we could name the first gift as a Recurring gift and all subsequent gifts as Recurring Gift - Cash - This would allow analytics to focus just on the first gift when needed.

@Cstone They are the same. Civi just uses contributions for the tab on a donor record so it's my default :)

@NNichols thanks for the explanation, is gift just more widely used outside of WMF? We've just had some confusion on if a gift is just a contribution or not, so would a Recurring Contribution and then Recurring Contribution - Cash be equivalent names?

I'm not familiar with the naming conventions in this case, please share more details if you need more input. I'll leave it though to Joseph to decide

Currently I derive whether a recurring donation (gift/contribution/etc.) is a sign up or further recurring donation after the sign-up in my reporting cubes/queries using functions like:

for pre-payment recurring:

ROW_NUMBER() OVER (PARTITION BY contribution_recur_id ORDER BY receive_date ASC) - 1 AS recur_donation_number

I also do this for post-payment recurring, but it is more complicated and requires a combo of civicrm_contribution and civicrm_contribution_recur since a contribution_recur_id does not populate in civicrm_contribution for the one time gift that prompts the sign-up for what we call post-payment recurring.

CASE
        WHEN create_date IS NULL AND contribution_recur_id IS NULL THEN NULL
        WHEN create_date IS NOT NULL THEN 0
        ELSE ROW_NUMBER() OVER (PARTITION BY contribution_recur_id ORDER BY receive_date ASC)
    END AS recur_donation_number

What these do is output 0 for the sign up donation, 1 for the first donation after sign-up, 2 for the second donation after sign-up, etc.

If there is a way for ya'll to do this (or something similar) on the database/civi side, that would allow me to clean up my code quite a bit, and potentially consolidate to one less data cube to maintain.

@NNichols that seems like a +1 on 2 type s- eg

'Recurring GIft' for the first and 'Recurring Gift Subsequent' for all follow ons

Great! Since we're changing the language of Financial Type to actual financial types let's go with Recurring Gift for the first and Recurring Gift - Cash for all subsequent.

I also wonder is there a way in civi to number the gifts as Joseph was saying he does? Meaning if I click on any random recurring gift in a donor's record I can easily see what number this is for this particular setup?

@NNichols Can I sell you on just 'Recurring - first' and 'Recurring' (we are still struggling with 'Cash' when is actually paypal or whatever).

My apologies. I didn't hit submit yesterday.

The payment method (eg Paypal) is stored elsewhere. We're really trying to move towards using more industry standard terms for some of these fields so in this financial type let's definitely go with Recurring Gift and then Recurring Gift - Cash for subsequent.
Cash here will refer to all gifts that are cash on hand, meaning they aren't stock, in kind, or pledge.

When we first started talking about this our goal was to get this in place for the month of August. Is that still doable and how can we retroactively relabel July 2023 so we can keep this fiscal year with all the same coding?

Change 946969 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[wikimedia/fundraising/crm@master] WIP: Use Financial Type= "Recurring Gifts" for all first recurring contribution and "Recurring Gifts - Cash" for subsequent donations.

https://gerrit.wikimedia.org/r/946969

Change 946969 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Use Financial Type= "Recurring Gifts" for all first recurring contribution and "Recurring Gifts - Cash" for subsequent donations.

https://gerrit.wikimedia.org/r/946969

I just reviewed & deployed Dami's patch - 2 contributions have been created so far - they seem good...

https://civicrm.wikimedia.org/civicrm/admin/search#/create/Contribution?params=%7B%22version%22:4,%22select%22:%5B%22id%22,%22financial_type_id:label%22,%22receive_date%22,%22contact_id.display_name%22%5D,%22orderBy%22:%7B%7D,%22where%22:%5B%5B%22financial_type_id:name%22,%22IN%22,%5B%22Recurring%20Gift%22,%22Recurring%20Gift%20-%20Cash%22%5D%5D%5D,%22groupBy%22:%5B%5D,%22join%22:%5B%5D,%22having%22:%5B%5D%7D