Page MenuHomePhabricator
Create Task
Maniphest T341419

Run all maintenance files in --dry-run mode and see if there would be changes
Closed, InvalidPublic
Actions

Description

It looks like most of the PageTriage maintenance scripts in the maintenance folder are meant to fix SQL bugs that crop up over time.

  • make sure they all have a --dry-run mode that doesn't change anything, just shows how many changes it would make in non dry run mode. If no --dry-run mode, change the code to add a --dry-run mode.
  • add integration tests to make sure that --dry-run is actually dry run
  • identify which maintenance scripts are meant for fixing bugs, then run them with --dry-run and note which ones identify issues
  • make Phab tickets for those, to investigate and fix the root causes of the bugs

For example, running maintenance/cleanupPageTriage.php --dry-run will probably identify thousands of entries. See screenshot in T321982: Unexpected namespaces in pagetriage_page table

Related Objects

Event Timeline

Novem_Linguae created this task.Jul 8 2023, 8:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2023, 8:47 PM
Novem_Linguae moved this task from Backlog to Priority bugs on the PageTriage board.Jul 8 2023, 8:48 PM
Novem_Linguae closed this task as Invalid.Jul 9 2023, 8:33 PM

I thought of a better idea. I looked up each maintenance script's first commit instead, which usually talked about the "why". Closing this in favor of other tickets/approaches.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits