Page MenuHomePhabricator

Publish mwbot-rs docs on doc.wikimedia.org
Open, Needs TriagePublic

Details

TitleReferenceAuthorSource BranchDest Branch
Publish docs on doc.wikimedia.orgrepos/mwbot-rs/toolforge!12legoktmdocsmain
Don't clobber docpub's after_scriptrepos/mwbot-rs/rust-ci-pipeline!9legoktmfix-docsmain
Publish docs to doc.wikimedia.orgrepos/mwbot-rs/mwbot!48legoktmdocsmain
Publish docs to doc.wikimedia.orgrepos/mwbot-rs/rust-ci-pipeline!7legoktmdocsmain
Add mwbot-rs repositories to allowed_projectsrepos/releng/docpub!2legoktmlegoktm-main-patch-37581main
Customize query in GitLab

Event Timeline

Hm, something went wrong :/

Traceback (most recent call last):
  File "/usr/local/bin/docpub.py", line 185, in <module>
    docs_dir = os.path.join(artifacts_dir, os.getenv('DOC_PRJ_DOCS_DIR'))
  File "/usr/lib/python3.9/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib/python3.9/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

Any idea what is missing @jnuche?

Fixed that, now it's https://releases-jenkins.wikimedia.org/job/docpub/75/console:

Traceback (most recent call last):
  File "/usr/local/bin/docpub.py", line 187, in <module>
    normalized_pub_location = normalize_doc_location(os.getenv('PUB_LOCATION'))
  File "/usr/local/bin/docpub.py", line 42, in normalize_doc_location
    return re.sub(r'^([^/-]*)-?repos', r'\g<1>', path.removeprefix('/')).removeprefix('/')
AttributeError: 'NoneType' object has no attribute 'removeprefix'

Stopping for now, will get back to this later. Would be great if docpub failed a little more clearly when things don't go as expected instead of type and attribute errors :/

Stopping for now, will get back to this later. Would be great if docpub failed a little more clearly when things don't go as expected instead of type and attribute errors :/

Agreed, I'm going to improve the error messages.

PUB_LOCATION is required and by default populated with your project path, but you're overriding it here. That's causing the job to fail. More details in the README.

Wow I'm an idiot, I don't know why I did that. I'll at least send a docs MR for the after_script issue to make up for that >.<

Change 938025 had a related patch set uploaded (by Legoktm; author: Legoktm):

[integration/docroot@master] Add mwbot-rs to doc.wikimedia.org

https://gerrit.wikimedia.org/r/938025

Change 938025 merged by jenkins-bot:

[integration/docroot@master] Add mwbot-rs to doc.wikimedia.org

https://gerrit.wikimedia.org/r/938025

Mentioned in SAL (#wikimedia-operations) [2023-07-14T07:13:31Z] <hashar@deploy1002> Started deploy [integration/docroot@56b5745]: Add mwbot-rs to doc.wikimedia.org - T341543

Mentioned in SAL (#wikimedia-operations) [2023-07-14T07:13:39Z] <hashar@deploy1002> Finished deploy [integration/docroot@56b5745]: Add mwbot-rs to doc.wikimedia.org - T341543 (duration: 00m 08s)

Wow I'm an idiot, I don't know why I did that. I'll at least send a docs MR for the after_script issue to make up for that >.<

Not at all, happens to the best of us.

And publishing is now working, awesome! https://releases-jenkins.wikimedia.org/job/docpub/83/console

Poked at coverage reports today (https://doc.wikimedia.org/cover/mwbot-rs/mwbot/coverage/), except they're mostly broken since grcov tries to load some JS from the jsdelivr CDN :/

Filed https://github.com/mozilla/grcov/issues/1079 for that.