Page MenuHomePhabricator
Create Task
Maniphest T341603

ctrl+shift+p to launch toolbar search doesn't work on Firefox
Closed, ResolvedPublic
Actions

Description

In T66905#8947788, @Sebastian_Berlin-WMSE wrote:

Ctrl+shift+p doesn't work for me (backslash does). This is on Ubuntu 22.04 and Firefox 114. What happens instead is that a private window is opened, which is the normal behaviour in Firefox.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (ca5f6c26d)DLynchmediawiki/extensions/VisualEditormaster+1 -1
Provide alternate keyboard shortcut for toolbar search for mac FirefoxDLynchVisualEditor/VisualEditormaster+5 -2
Update VE core submodule to master (245923176)Bartosz Dziewońskimediawiki/extensions/VisualEditormaster+2 -1
Provide alternate keyboard shortcut for toolbar search for FirefoxEsandersVisualEditor/VisualEditormaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 11 2023, 5:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2023, 5:46 PM
Esanders mentioned this in T66905: VisualEditor: Provide an omnibar for quick keyboard access to tools.Jul 11 2023, 5:46 PM
gerritbot added a comment.Jul 11 2023, 5:53 PM

Change 937162 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Provide alternate keyboard shortcut for toolbar search for Firefox

https://gerrit.wikimedia.org/r/937162

gerritbot added a project: Patch-For-Review.Jul 11 2023, 5:53 PM
gerritbot added a comment.Jul 11 2023, 9:07 PM

Change 937162 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Provide alternate keyboard shortcut for toolbar search for Firefox

https://gerrit.wikimedia.org/r/937162

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 9:10 PM
gerritbot added a comment.Jul 11 2023, 9:14 PM

Change 937182 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (245923176)

https://gerrit.wikimedia.org/r/937182

gerritbot added a project: Patch-For-Review.Jul 11 2023, 9:14 PM
gerritbot added a comment.Jul 11 2023, 9:31 PM

Change 937182 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (245923176)

https://gerrit.wikimedia.org/r/937182

• matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 11 2023, 9:37 PM
• matmarex added a project: Editing-team (Kanban Board).
• matmarex moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
• matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 11 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 10:10 PM
Esanders added a comment.Jul 12 2023, 9:56 AM

The above patch adds ctrl+alt+shift+p as an alternate shortcut

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Aug 4 2023, 2:44 AM
Ryasmeen subscribed.

This seems to be not working for me on Firefox.

Ryasmeen removed a project: Editing QA.Aug 4 2023, 2:52 AM
DLynch subscribed.Aug 28 2023, 5:32 PM

Agreed, this isn't working for me in Firefox (macOS).

DLynch added a comment.Sep 11 2023, 5:22 PM

Oh, right, the patch only added it for pc, and @Ryasmeen is probably also testing it on mac. We should adjust that -- cmd-shift-p has the same issue as ctrl-shift-p does on windows. Same fix should work -- cmd-alt-shift-p doesn't seem to have any collisions.

Pols12 subscribed.Sep 27 2023, 11:29 PM

I confirm Ctrl+Alt+Shift+P does properly work on Debian GNU/Linux.

gerritbot added a comment.Sep 27 2023, 11:52 PM

Change 961488 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] Provide alternate keyboard shortcut for toolbar search for mac Firefox

https://gerrit.wikimedia.org/r/961488

gerritbot added a project: Patch-For-Review.Sep 27 2023, 11:52 PM
DLynch added a comment.Sep 27 2023, 11:52 PM

Thanks for the nudge, I thought I'd already written that patch. 😂

DLynch moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Sep 27 2023, 11:52 PM
gerritbot added a comment.Sep 28 2023, 4:07 PM

Change 961488 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Provide alternate keyboard shortcut for toolbar search for mac Firefox

https://gerrit.wikimedia.org/r/961488

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 4:10 PM
gerritbot added a comment.Oct 2 2023, 9:44 PM

Change 962711 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca5f6c26d)

https://gerrit.wikimedia.org/r/962711

gerritbot added a project: Patch-For-Review.Oct 2 2023, 9:44 PM
gerritbot added a comment.Oct 2 2023, 10:41 PM

Change 962711 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca5f6c26d)

https://gerrit.wikimedia.org/r/962711

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 11:10 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 17 2023, 5:02 PM
DLynch added a project: Editing QA.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 5 2023, 12:41 AM
Ryasmeen edited projects, added: Verified; removed: Editing QA.
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:52 PM
VPuffetMichel claimed this task.
VPuffetMichel removed VPuffetMichel as the assignee of this task.
VPuffetMichel subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits