Page MenuHomePhabricator
Create Task
Maniphest T341779

Move encodeJsVar() and encodeJsCall() from Xml to Html class
Closed, ResolvedPublic
Actions

Description

Xml::encodeJsVar() and Xml::encodeJsCall() are fairly widely used (though often only a handful of times per extension), see codesearch. They’re clearly dealing with a pretty HTML-specific concern, and should thus live in the Html class instead.

  • Add to Html class
    • The Xml implementation can probably just call the Html version
    • Rename XmlJsCode to HtmlJsCode and leave a class_alias behind? (It’s not actually used outside of core according to codesearch, but I think it’s technically part of the stable interface, and the class_alias shouldn’t hurt much.)
  • Soft-deprecate Xml version
  • Update Wikimedia-deployed callers
  • Hard-deprecate Xml version, in MW 1.44 (patch)
  • Remove Xml version, in MW 1.45+

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 13 2023, 10:33 AM
• matmarex subscribed.Jul 13 2023, 12:31 PM
Jdforrester-WMF subscribed.Jul 13 2023, 1:04 PM
gerritbot added a comment.Jul 13 2023, 3:46 PM

Change 937976 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Html: Move encodeJsVar() + encodeJsCall() from Xml

https://gerrit.wikimedia.org/r/937976

gerritbot added a project: Patch-For-Review.Jul 13 2023, 3:46 PM
gerritbot added a comment.Jul 14 2023, 10:38 AM

Change 938219 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use Html::encodeJsVar()

https://gerrit.wikimedia.org/r/938219

Jdforrester-WMF updated the task description. (Show Details)Jul 14 2023, 5:49 PM
gerritbot added a comment.Jul 14 2023, 6:03 PM

Change 937976 merged by jenkins-bot:

[mediawiki/core@master] Html: Move encodeJsVar() + encodeJsCall() from Xml

https://gerrit.wikimedia.org/r/937976

Jdforrester-WMF added a project: Technical-Debt (Deprecation process).Jul 14 2023, 6:08 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 14 2023, 7:00 PM
gerritbot added a comment.Jul 15 2023, 12:52 AM

Change 938219 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use Html::encodeJsVar()

https://gerrit.wikimedia.org/r/938219

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2023, 1:10 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 17 2023, 10:15 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jul 20 2023, 2:48 PM

Change 940173 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Use Html::encodeJsVar() and Html::encodeJsCall()

https://gerrit.wikimedia.org/r/940173

gerritbot added a project: Patch-For-Review.Jul 20 2023, 2:48 PM
gerritbot added a comment.Jul 20 2023, 5:58 PM

Change 940173 merged by jenkins-bot:

[mediawiki/core@master] Use Html::encodeJsVar() and Html::encodeJsCall()

https://gerrit.wikimedia.org/r/940173

ReleaseTaggerBot edited projects, added: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 20 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 20 2023, 6:10 PM
Krinkle moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Mar 27 2024, 6:51 PM
gerritbot added a comment.Apr 29 2024, 10:33 AM

Change #1025294 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Stop using the Xml class in this codebase

https://gerrit.wikimedia.org/r/1025294

gerritbot added a project: Patch-For-Review.Apr 29 2024, 10:33 AM
thiemowmde updated the task description. (Show Details)Apr 29 2024, 10:40 AM
thiemowmde subscribed.
gerritbot added a comment.Apr 29 2024, 10:52 AM

Change #1025298 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Gadgets@master] Stop using the Xml class in this codebase

https://gerrit.wikimedia.org/r/1025298

gerritbot added a comment.Apr 29 2024, 11:24 AM

Change #1025298 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Stop using the Xml class in this codebase

https://gerrit.wikimedia.org/r/1025298

gerritbot added a comment.Apr 29 2024, 11:42 AM

Change #1025294 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Stop using the Xml class in this codebase

https://gerrit.wikimedia.org/r/1025294

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 29 2024, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2024, 12:31 PM
Jdforrester-WMF updated the task description. (Show Details)Jul 23 2024, 1:42 PM
gerritbot added a comment.Jul 23 2024, 1:44 PM

Change #1056159 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralAuth@master] SpecialCentralAutoLogin: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056159

gerritbot added a project: Patch-For-Review.Jul 23 2024, 1:44 PM

Change #1056160 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@master] MobileConfig: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056160

gerritbot added a comment.Jul 23 2024, 1:48 PM

Change #1056161 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DismissableSiteNotice@master] Hooks: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056161

gerritbot added a comment.Jul 23 2024, 2:20 PM

Change #1056170 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/UniversalLanguageSelector@master] ResourceLoaderULSJsonMessageModule: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056170

gerritbot added a comment.Jul 23 2024, 2:22 PM

Change #1056171 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DonationInterface@master] [DNM] CurrencyRatesModule: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056171

gerritbot added a comment.Jul 23 2024, 3:04 PM

Change #1056160 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileConfig: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056160

gerritbot added a comment.Jul 23 2024, 3:04 PM

Change #1056170 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ResourceLoaderULSJsonMessageModule: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056170

gerritbot added a comment.Jul 23 2024, 3:04 PM

Change #1056159 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialCentralAutoLogin: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056159

gerritbot added a comment.Jul 23 2024, 3:04 PM

Change #1056161 merged by jenkins-bot:

[mediawiki/extensions/DismissableSiteNotice@master] Hooks: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056161

Jdforrester-WMF changed the task status from Open to Stalled.Jul 23 2024, 3:35 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Jul 23 2024, 4:00 PM
gerritbot added a comment.Mar 11 2025, 7:11 PM

Change #1056171 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] CurrencyRatesModule: Stop using Xml::encodeJsVar, deprecated

https://gerrit.wikimedia.org/r/1056171

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 7:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 11 2025, 8:00 PM
gerritbot added a comment.Mar 11 2025, 8:33 PM

Change #1126651 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Xml: Hard-deprecate encodeJsCall/encodeJsVar, no longer used in prod

https://gerrit.wikimedia.org/r/1126651

gerritbot added a project: Patch-For-Review.Mar 11 2025, 8:33 PM
Jdforrester-WMF changed the task status from Stalled to Open.Mar 11 2025, 8:35 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 11 2025, 9:44 PM

Change #1126651 merged by jenkins-bot:

[mediawiki/core@master] Xml: Hard-deprecate encodeJsCall/encodeJsVar, no longer used in prod

https://gerrit.wikimedia.org/r/1126651

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 10:31 PM
Jdforrester-WMF added a project: MW-1.45-release.Mar 12 2025, 12:58 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Blocker to Deprecate or remove on the MW-1.45-release board.
gerritbot added a comment.Oct 15 2025, 10:08 PM

Change #1196532 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Drop many deprecated static methods of Xml abused to generate Html

https://gerrit.wikimedia.org/r/1196532

gerritbot added a project: Patch-For-Review.Oct 15 2025, 10:08 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 15 2025, 10:26 PM
Jdforrester-WMF claimed this task.
gerritbot added a comment.Oct 16 2025, 11:01 AM

Change #1196532 merged by jenkins-bot:

[mediawiki/core@master] Drop many deprecated static methods of Xml abused to generate Html

https://gerrit.wikimedia.org/r/1196532

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2025, 11:31 AM
• matmarex closed this task as Resolved.Oct 18 2025, 10:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits