ParameterTypeException: Bad value for parameter $taskType: must be a ImageRecommendationBaseTaskType
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Jul 13 2023, 3:39 PM

Description

Error

service.version: 1.41.0-wmf.16
trace.id: 3020c9de-d446-41ff-bc6c-1217dcf57fe0
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Wikimedia\Assert\ParameterTypeException: Bad value for parameter $taskType: must be a GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationBaseTaskType

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.16/vendor/wikimedia/assert/src/Assert.php(105)
#0 /srv/mediawiki/php-1.41.0-wmf.16/extensions/GrowthExperiments/includes/Api/ApiInvalidateImageRecommendation.php(69): Wikimedia\Assert\Assert::parameterType(array, NULL, string)
#1 /srv/mediawiki/php-1.41.0-wmf.16/includes/api/ApiMain.php(1915): GrowthExperiments\Api\ApiInvalidateImageRecommendation->execute()
#2 /srv/mediawiki/php-1.41.0-wmf.16/includes/api/ApiMain.php(892): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.41.0-wmf.16/includes/api/ApiMain.php(863): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.41.0-wmf.16/api.php(95): ApiMain->execute()
#5 /srv/mediawiki/php-1.41.0-wmf.16/api.php(48): wfApiMain()
#6 /srv/mediawiki/w/api.php(3): require(string)
#7 {main}

Impact

Notes

Looks like getTaskTypes() can return empty array, as acknowledged by getTaskTypes()[…] ?? null in the code, but that means the fatal error is "expected" which needs to be addressed somehow.

Details

Request URL: https://en.wikipedia.org/w/api.php?action=growthinvalidateimagerecommendation&errorformat=*&errorsuselocal=*&format=*&formatversion=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ApiInvalidateImageRecommendation: Error out nicely if task type is not available	mediawiki/extensions/GrowthExperiments	master	+32 -0

Customize query in gerrit

Related Objects

Mentioned In: T341150: Ensure growthimagesuggestiondata API works on all Wikipedias
Mentioned Here: T337330: Wikimedia\Assert\ParameterTypeException: Bad value for parameter $taskType: must be a GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationBaseTaskType
T341150: Ensure growthimagesuggestiondata API works on all Wikipedias

Event Timeline

Krinkle created this task.Jul 13 2023, 3:39 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 13 2023, 3:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle moved this task from Untriaged to Jul 2023 on the Wikimedia-production-error board.Jul 13 2023, 3:39 PM

Sgs moved this task from Inbox to Sprint 0 (Growth Team) on the Growth-Team board.Jul 14 2023, 11:38 AM

Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Sgs moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 14 2023, 12:18 PM

In T341150: Ensure growthimagesuggestiondata API works on all Wikipedias, we added image-recommendation and section-image-recommendation to the NewcomerTasks.json config file on all Wikipedias. This enabled ApiQueryImageSuggestionData (which had a similar error, cf. T337330), but not ApiInvalidateImageRecommendation, because the invalidation API only checks ConfigurationLoader::getTaskTypes, not ConfigurationLoader::getDisabledTaskTypes as well (which happens in ApiQueryImageSuggestionData). Essentially, the invalidation API requires the image recommendation task types to be enabled to work properly.

Since the Android app plans to use the image suggestions feature and re-use the APIs Growth team has, we need to make the invalidation API working even when the task is disabled in the configuration. We can do that by merging ConfigurationLoader::getTaskTypes and ConfigurationLoader::getDisabledTaskTypes in the API, similar to ApiQueryImageSuggestionData.

In T341813#9026717, @Urbanecm_WMF wrote:

In T341150: Ensure growthimagesuggestiondata API works on all Wikipedias, we added image-recommendation and section-image-recommendation to the NewcomerTasks.json config file on all Wikipedias. This enabled ApiQueryImageSuggestionData (which had a similar error, cf. T337330), but not ApiInvalidateImageRecommendation, because the invalidation API only checks ConfigurationLoader::getTaskTypes, not ConfigurationLoader::getDisabledTaskTypes as well (which happens in ApiQueryImageSuggestionData). Essentially, the invalidation API requires the image recommendation task types to be enabled to work properly.

Since the Android app plans to use the image suggestions feature and re-use the APIs Growth team has, we need to make the invalidation API working even when the task is disabled in the configuration. We can do that by merging ConfigurationLoader::getTaskTypes and ConfigurationLoader::getDisabledTaskTypes in the API, similar to ApiQueryImageSuggestionData.

Actually, ApiInvalidateImageRecommendation checks whether the invalidated article is in the user's task set. That definitely won't happen now with Android app (as the task is not enabled, so users don't have access to it through Growth features), and it wouldn't happen even if the task was enabled everywhere (because the user might not have it enabled at any given time).

How should invalidation for Android app be handled?

Urbanecm_WMF mentioned this in T341150: Ensure growthimagesuggestiondata API works on all Wikipedias.Jul 19 2023, 9:46 AM

Change 939645 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ApiInvalidateImageRecommendation: Error out nicely if task type is not available

https://gerrit.wikimedia.org/r/939645

gerritbot added a project: Patch-For-Review.Jul 19 2023, 10:15 AM

Change 939645 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ApiInvalidateImageRecommendation: Error out nicely if task type is not available

https://gerrit.wikimedia.org/r/939645

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 5:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 21 2023, 6:00 PM

The error is resolved by the patch above; the T341813#9026754 question will be discussed as part of T341150.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 27 2023, 2:45 PM

The last time stamp for the error- Jul 19, 2023 @ 19:14:47.592 (logstash link).

ParameterTypeException: Bad value for parameter $taskType: must be a ImageRecommendationBaseTaskTypeClosed, ResolvedPublicPRODUCTION ERRORActions