Maniphest T342048

Icons have no color in vector 2010 or monobook
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Novem_Linguae
	Jul 17 2023, 9:04 PM

Description

Steps to replicate the issue (include links if applicable):

https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed?useskin=vector&ui_version=1

What happens?:

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add CSS rule for warning icon	mediawiki/extensions/PageTriage	master	+3 -0
	Fix colors in NewPagesFeed icons	mediawiki/extensions/PageTriage	master	+7 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T335074 Rewrite PageTriage front-end in Vue.js
Resolved		jsn.sherman	T402256 Rewrite PageTriage Special:NewPagesFeed in Vue.js
Resolved	Spike	jsn.sherman	T324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo
Resolved	BUG REPORT	Scardenasmolinar	T342048 Icons have no color in vector 2010 or monobook

Event Timeline

Novem_Linguae created this task.Jul 17 2023, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2023, 9:04 PM

Novem_Linguae moved this task from Backlog to Vue migration bugs on the PageTriage board.Jul 17 2023, 9:20 PM

Novem_Linguae updated the task description. (Show Details)

Novem_Linguae renamed this task from Icons have no color in vector 2010 to Icons have no color in vector 2010 or monobook.Jul 17 2023, 9:40 PM

Samwalton9-WMF added a parent task: T324914: Add [[User:DannyS712/VueNPP.js]] to PageTriage repo.Jul 18 2023, 9:20 AM

Samwalton9-WMF added a project: Moderator-Tools-Team (Kanban).Jul 18 2023, 4:14 PM

Scardenasmolinar changed the task status from Open to In Progress.Aug 1 2023, 1:15 AM

Scardenasmolinar claimed this task.

Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 943653 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Fix colors in NewPagesFeed icons

https://gerrit.wikimedia.org/r/943653

gerritbot added a project: Patch-For-Review.Aug 1 2023, 2:26 AM

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Aug 1 2023, 2:59 AM

Novem_Linguae moved this task from Vue migration bugs to Code Review on the PageTriage board.Aug 1 2023, 6:30 PM

jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Aug 1 2023, 7:27 PM

jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.

Change 943653 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix colors in NewPagesFeed icons

https://gerrit.wikimedia.org/r/943653

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 1 2023, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2023, 8:10 PM

Samwalton9-WMF closed this task as Resolved.Aug 22 2023, 4:08 PM

This bug is partially back on old vector. Steps to reproduce:

Create a brand new, unreviewed page
Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed?ui_version=1&useskin=vector

The below black triangle icon should be yellow

Novem_Linguae moved this task from Waiting for enwiki deploy to Vue migration bugs on the PageTriage board.Aug 29 2023, 1:03 PM

jsn.sherman moved this task from Done to Ready on the Moderator-Tools-Team (Kanban) board.Aug 29 2023, 1:06 PM

Thanks for pointing that out! I'll set up a patch and a patch demo so you can test the changes @Novem_Linguae

Change 953335 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Add CSS rule for warning icon

https://gerrit.wikimedia.org/r/953335

gerritbot added a project: Patch-For-Review.Aug 29 2023, 7:19 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/69a530f67e/w

@Novem_Linguae you can check the patch above and compare it to https://patchdemo.wmflabs.org/wikis/de5974d4d8/wiki/Special:NewPagesFeed?ui_version=1 to see if the error has resolved. I see the icon color change in this patch demo.

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Aug 29 2023, 7:54 PM

I tested the patchdemo on monobook:
https://patchdemo.wmflabs.org/wikis/69a530f67e/w/index.php?title=Special:NewPagesFeed&ui_version=1&useskin=monobook&mobileaction=toggle_view_desktop
and vector 2010:
https://patchdemo.wmflabs.org/wikis/69a530f67e/w/index.php?title=Special:NewPagesFeed&ui_version=1&useskin=vector&mobileaction=toggle_view_desktop
and both have the appropriate color.

jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Sep 7 2023, 5:43 PM

Change 953335 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add CSS rule for warning icon

https://gerrit.wikimedia.org/r/953335

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Sep 8 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2023, 4:10 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/69a530f67e/w/~~

Samwalton9-WMF closed this task as Resolved.Sep 15 2023, 9:23 AM

	F37640460: image.png
	Aug 29 2023, 1:03 PM

Icons have no color in vector 2010 or monobookClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Icons have no color in vector 2010 or monobook
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...