Page MenuHomePhabricator

New iconset does not match Page Curation toolbar and is (arguably) less aesthetic
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Novem_Linguae
Jul 17 2023, 9:16 PM
Referenced Files
F37160672: image.png
Aug 2 2023, 5:45 PM
F37160569: image.png
Aug 2 2023, 5:41 PM
F37160556: image.png
Aug 2 2023, 5:41 PM
F37160558: image.png
Aug 2 2023, 5:41 PM
F37160554: image.png
Aug 2 2023, 5:41 PM
F37160560: image.png
Aug 2 2023, 5:41 PM
F37160567: image.png
Aug 2 2023, 5:41 PM
F37141760: image.png
Jul 17 2023, 9:16 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (107×147 px, 2 KB)

image.png (106×127 px, 1 KB)

What should have happened instead?:

image.png (79×108 px, 3 KB)

image.png (70×98 px, 2 KB)

image.png (69×106 px, 2 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Let's say hypothetically we kept these new icons. What's our plan for getting them to match up with the Page Curation toolbar? 3 of the 4 new icons are not circular, so cannot be displayed on the Page Curation toolbar itself like we currently do.

image.png (173×102 px, 6 KB)

image.png (136×86 px, 8 KB)

image.png (155×89 px, 9 KB)

image.png (265×91 px, 13 KB)

Event Timeline

Thank you for writing this up. It was definitely not my intention to leave these as they are. As codex has released more icons, and I've become more comfortable using it, I think I can significantly improve this situation.

Keeping in mind that we programatically apply color to codex icons, we now have access to icons such as:

cdxIconInfo / cdxIconInfoFilled:

image.png (80×86 px, 1 KB)

cdxIconHeart:

image.png (80×86 px, 1 KB)

cdxIconSuccess:

image.png (80×86 px, 2 KB)

cdxIconTag:

image.png (80×86 px, 1 KB)

cdxIconTrash:

image.png (80×86 px, 606 B)

cdxIconArrowNext:

image.png (80×86 px, 680 B)

I can update the checkmark and trash icons in the feed now. For the toolbar, we should be able to wrap the non-round icons in radiused elements to give them a round appearance. I would wait until all tools/buttons are migrated before swapping in any of the new icons there.

There are several options for the minimize icon. I actually find the current icon confusing. I did see a task for dropping the minimize functionality in favor of close, in which case I would probably just use:
cdxIconClose:

image.png (50×56 px, 676 B)

You can see all currently availble icons here:
https://doc.wikimedia.org/codex/latest/icons/all-icons.html

I think just copying the old UI and icons is always going to be the easiest choice. The old UI and icons have implicit consensus because it's been that way for years. People are used to it and there is no decision paralysis there, no need for discussions, no delays.

WMF changing visual appearance and forcing it on users is controversial. I am still bitter about how Vector 2022 was handled, and I'm not the only one. When we can, I suggest we keep the UI the same.

Would it be hard to just <img src=""> to the old icons?

I think just copying the old UI and icons is always going to be the easiest choice. The old UI and icons have implicit consensus because it's been that way for years. People are used to it and there is no decision paralysis there, no need for discussions, no delays.

That's certainly a point in favor of uncoupling this proposed change from the underlying migration away from backbone.

WMF changing visual appearance and forcing it on users is controversial. I am still bitter about how Vector 2022 was handled, and I'm not the only one. When we can, I suggest we keep the UI the same.

There is no mandate from on high to force change here. This change is just me trying to opportunistically apply our current technologies to this extension to pick up the benefits of engineering and design of our current stack.

There are real advantages to using the new icon set (more for the toolbar than the feed), though they may not seem like big advantages at first glance. The new icons are vector images meaning they stay pin sharp at any scale. They have 1-bit color, meaning they can provide maximum color contrast. They would be a real improvement for folks that need magnification. In the future (after the toolbar is migrated completely), I also would love to add keyboard navigation and aria roles to make it usable with screen readers, as it's currently invisible to them. I don't want to take any autonomy away from this community, but I do want the technology of the website to enable anyone who wishes to participate to be able to.

Would it be hard to just <img src=""> to the old icons?

It would not be hard, that's basically what I've done in the toolbar task for the moment, since mixing and matching the two icon sets on the same page would be really inconsistent. The main benefit of making the change to the new pages feed now is that there would be an implementation as a model right here in the repo to use as an example in moving the toolbar over. Keeping the old icons for now is not a terrible outcome.

I ask you consider my perspective separately from the Vector 2022 implementation to the extent you are able.

I sat with this for a while, and will do it as you've asked. The other codex bits that I've implemented directly sped up building this interface. I think moving to the new icon set makes sense, but it's no easier or harder to implement than what was there before.

Change 945849 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] New Pages Feed: use existing icon set

https://gerrit.wikimedia.org/r/945849

Change 945849 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] New Pages Feed: use existing icon set

https://gerrit.wikimedia.org/r/945849