Page MenuHomePhabricator
Create Task
Maniphest T342158

Mobile diff: inline switch should not be shown
Closed, ResolvedPublic
Actions

Assigned To
• MusikAnimal
Authored By
HMonroy
Jul 18 2023, 7:05 PM
Tags
Referenced Files
F37152454: T342158_BetterDiffs_MobileDiff_Safari2.png
Jul 27 2023, 10:27 PM
F37152452: T342158_BetterDiffs_MobileDiff_Edge2.png
Jul 27 2023, 10:27 PM
F37152450: T342158_BetterDiffs_MobileDiff_Firefox2.png
Jul 27 2023, 10:27 PM
F37152447: T342158_BetterDiffs_MobileDiff_Chrome2.png
Jul 27 2023, 10:27 PM
F37152444: T342158_BetterDiffs_MobileDiff_ios.png
Jul 27 2023, 10:27 PM
F37152442: T324759_BetterDiffs_MobileDiff_Edge.png
Jul 27 2023, 10:27 PM
F37152440: T324759_BetterDiffs_MobileDiff_Firefox.png
Jul 27 2023, 10:27 PM
F37152438: T342158_BetterDiffs_MobileDiff_Chrome.png
Jul 27 2023, 10:27 PM
View All 9 Files
Subscribers
Aklapper
GMikesell-WMF
HMonroy

Description

Inline switch should not show in mobile diff

The inline switch is currently showing up in mobile diff

Screenshot from 2023-07-18 12-03-26.png (519×1 px, 105 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't show the inline toggle selector on Special:MobileDiffmediawiki/coremaster+29 -3
Customize query in gerrit

Related Objects

Event Timeline

HMonroy created this task.Jul 18 2023, 7:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2023, 7:05 PM
Jdlrobson mentioned this in T330247: Inline diff: one or more lines added or deleted.Jul 21 2023, 8:50 PM
gerritbot added a comment.Jul 26 2023, 5:16 AM

Change 941029 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Don't show the inline toggle selector on Special:MobileDiff

https://gerrit.wikimedia.org/r/941029

gerritbot added a project: Patch-For-Review.Jul 26 2023, 5:16 AM
gerritbot added a comment.Jul 26 2023, 9:47 AM

Change 941029 merged by jenkins-bot:

[mediawiki/core@master] Don't show the inline toggle selector on Special:MobileDiff

https://gerrit.wikimedia.org/r/941029

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 26 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 10:10 AM
HMonroy moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Jul 27 2023, 5:04 AM
HMonroy moved this task from Review/Feedback 💬 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
HMonroy moved this task from Done 🏁 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.
GMikesell-WMF subscribed.Jul 27 2023, 10:27 PM

@HMonroy I did not come across any inline in mobile diff as seen in the screenshots below. I will move this to Done. Thanks for your work!

OS: macOS 13.4, Windows 11
Browsers: Chrome 115, Firefox 115, Edge 114, Safari 16.5
Test link: https://en.m.wikipedia.org/wiki/Special:MobileDiff/1166429509

**Type*ChromeFirefoxEdgeSafari
Mobile Desktop
T342158_BetterDiffs_MobileDiff_Chrome.png (1×520 px, 270 KB)
T324759_BetterDiffs_MobileDiff_Firefox.png (1×535 px, 353 KB)
T324759_BetterDiffs_MobileDiff_Edge.png (1×514 px, 224 KB)
T342158_BetterDiffs_MobileDiff_ios.png (1×515 px, 264 KB)
Mobile Phone
T342158_BetterDiffs_MobileDiff_Chrome2.png (882×1 px, 242 KB)
T342158_BetterDiffs_MobileDiff_Firefox2.png (1×2 px, 837 KB)
T342158_BetterDiffs_MobileDiff_Edge2.png (1×1 px, 1 MB)
T342158_BetterDiffs_MobileDiff_Safari2.png (941×1 px, 658 KB)
GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Jul 27 2023, 10:29 PM
• MusikAnimal closed this task as Resolved.Aug 2 2023, 6:16 PM
• MusikAnimal claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits