Page MenuHomePhabricator

Make WMF custom Phab extensions and code work with PHP8
Closed, ResolvedPublic

Description

This problem (upgrading to Debian 12 with PHP 8) is still probably more than a year away for us as Debian 11 will still include PHP 7.4, still creating this as a placeholder to make our code more robust (and actually test at some point once T333885 is done).

Ignore phabricator/extensions/src/gerrit/GerritProjectController.php to be eliminated in T228507.

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Make some strlen() calls be safe for PHP 8.0repos/phabricator/extensions!13aklapperT342244php8wmf/stable
Customize query in GitLab

Event Timeline

Aklapper triaged this task as Low priority.

Also, https://we.phorge.it/T15554 is the upstream ticket not to bark about PHP 8 deprecations but display them as Setup Errors to admins only.

Change #1020170 had a related patch set uploaded (by Aklapper; author: Aklapper):

[phabricator/translations@wmf/stable] Replace a strlen(null) call for PHP 8.1

https://gerrit.wikimedia.org/r/1020170

Change #1020170 merged by Brennen Bearnes:

[phabricator/translations@wmf/stable] Replace a strlen(null) call for PHP 8.1

https://gerrit.wikimedia.org/r/1020170

I think I hope that we're fine for now. If not I'll reopen.