Prevent incorrect variable name prefix in InitialiseSettings.php
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jul 19 2023, 1:13 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

cscott

Lucas_Werkmeister_WMDE

ssastry

Description

As far as I understand, wmf-config/InitialiseSettings.php should only contain settings with the following names:

prefix wg – direct settings for MediaWiki core / extensions/ skins
prefix wmg – used in some way in wmf-config/CommonSettings.php or somewhere else in the production config
groupOverrides and groupOverrides2 – very special settings

Any other array key is probably a mistake (e.g. UseLegacyMediaStyles instead of wgUseLegacyMediaStyles), and it would be nice if CI could notify the user about it, instead of the setting (probably) silently having no effect.

(I expect this also goes for e.g. wmf-config/core-Namespaces.php and all the other settings that were split out of the giant IS.php in T308932 – everything that goes into composer buildConfigCache.)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	tests: Test setting names	Lucas Werkmeister (WMDE)	operations/mediawiki-config	master	+16 -0

Customize query in gerrit

Related Objects

Mentioned Here: T308932: Iteratively clean up wmf-config to be less dynamic and with smaller settings files (2022)

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 19 2023, 1:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2023, 1:13 PM

ssastry awarded a token.Jul 19 2023, 1:28 PM

(At the moment, there are no other incorrect variable names AFAICT:)

$ time jq -r 'keys | .[]' tests/data/config-cache/*.json | grep -v -e '^wg' -e '^wmg' -e '^groupOverrides2\?$'

real    0m3,221s
user    0m3,301s
sys     0m0,075s

Change 939694 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] tests: Test setting names

https://gerrit.wikimedia.org/r/939694

gerritbot added a project: Patch-For-Review.Jul 19 2023, 1:43 PM

Lucas_Werkmeister_WMDE claimed this task.Jul 19 2023, 1:43 PM

Change 939694 merged by jenkins-bot:

[operations/mediawiki-config@master] tests: Test setting names

https://gerrit.wikimedia.org/r/939694

Mentioned in SAL (#wikimedia-operations) [2023-07-19T13:54:37Z] <Lucas_WMDE> pulled [[gerrit:939694|tests: Test setting names (T342249)]] to deploy1002 (no scap sync needed, tests-only change)

Done, I think. That was faster than expected :D

Lucas_Werkmeister_WMDE added a project: [Archived]Wikidata Dev Team (Sprint-∞).Jul 19 2023, 1:55 PM

Lucas_Werkmeister_WMDE set the point value for this task to 1.

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2023, 2:10 PM

Maintenance_bot added a project: Wikidata.Jul 19 2023, 2:30 PM

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Our work done on the [Archived]Wikidata Dev Team (Sprint-∞) board.Jul 21 2023, 1:42 PM

Prevent incorrect variable name prefix in InitialiseSettings.phpClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Prevent incorrect variable name prefix in InitialiseSettings.php
Closed, ResolvedPublic1 Estimated Story Points
Actions