Page MenuHomePhabricator

Requesting access to ops for taavi
Closed, ResolvedPublicRequest

Description

Requestor provided information and prerequisites

This section is to be completed by the individual requesting access.

  • Wikitech username: Majavah (uid=taavi)
  • Email address: hi+wm@taavi.wtf
  • SSH public key (must be a separate key from Wikimedia cloud SSH access): existing production shell account
  • Requested group membership: ops
  • Reason for access: I'm working on quite a few things (in WMCS land and elsewhere) and some of them aren't covered by my current access so this would be generally useful. Plus this gives Puppet merge access which would be quite useful. Nicholas said me requesting this is fine.
  • Name of approving party (manager for WMF/WMDE staff): @nskaggs
  • Ensure you have signed the L3 Wikimedia Server Access Responsibilities document: done a while back
  • Please coordinate obtaining a comment of approval on this task from the approving party.

SRE Clinic Duty Confirmation Checklist for Access Requests

This checklist should be used on all access requests to ensure that all steps are covered, including expansion to existing access. Please double check the step has been completed before checking it off.

This section is to be confirmed and completed by a member of the SRE team.

  • - User has signed the L3 Acknowledgement of Wikimedia Server Access Responsibilities Document.
  • - User has a valid NDA on file with WMF legal. (All WMF Staff/Contractor hiring are covered by NDA. Other users can be validated via the NDA tracking sheet)
  • - User has provided the following: wikitech username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)
  • - User has provided a public SSH key. This ssh key pair should only be used for WMF cluster access, and not shared with any other service (this includes not sharing with WMCS access, no shared keys.)
  • - The provided SSH key has been confirmed out of band and is verified not being used in WMCS.
  • - access request (or expansion) has sign off of WMF sponsor/manager (sponsor for volunteers, manager for wmf staff)
  • - access request (or expansion) has sign off of group approver indicated by the approval field in data.yaml

For additional details regarding access request requirements, please see https://wikitech.wikimedia.org/wiki/Requesting_shell_access

Event Timeline

Taavi is a valued contributor to Wikimedia and it's projects for over 4 years, and is the current Tech contributor of the year for Wikimedia. He possesses both the requisite skills and knowledge to safely carry this level of access, as well as the intention to use it to help keep our infrastructure operational.

As mentioned, Taavi has been restricted at times in his ability to help due to lacking access. See for example T337848, and T325067. Ourselves and movement would benefit from removing these restrictions.

Change 940269 had a related patch set uploaded (by Andrea Denisse; author: Andrea Denisse):

[operations/puppet@production] groups: Add taavi to the ops group

https://gerrit.wikimedia.org/r/940269

andrea.denisse changed the task status from Open to In Progress.Jul 21 2023, 12:36 AM
andrea.denisse updated the task description. (Show Details)

Hey - anything I can do to move this forward?

Hi @taavi !

Apologies for the delay this is taking.

Unfortunately the patch I sent to grant you access to ops (#940269) hasn't been reviewed yet and I can't merge it without at least a +1.

Could you please ask on IRC if someone can provide approval to the patch?

Looking forward to seeing you in ops! ^^

This needs approval by @mark or @joanna_borun (per data.yaml), I think. So I've tagged them to approve (or otherwise) this request :)

Apologies for the delay in completing this task. Our Infrastructure Foundations team is currently in the process of evaluating the global root access policy and potential enhancements to permissions. These improvements aim to provide sufficient access to our tools without requiring global root access. I will return with an update early next week. Thank you for your patience and understanding any inconvenience caused.

Change 949536 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] admin: add taavi to ops group

https://gerrit.wikimedia.org/r/949536

Change 949536 merged by Jbond:

[operations/puppet@production] admin: add taavi to ops group

https://gerrit.wikimedia.org/r/949536

Hi, I sent a patch for this change that was awaiting review.

https://gerrit.wikimedia.org/r/c/operations/puppet/+/940269/

Closing this task as resolved.

Change 940269 abandoned by Andrea Denisse:

[operations/puppet@production] groups: Add taavi to the ops group

Reason:

Abandoning as patch #949536 implements this functionality.

https://gerrit.wikimedia.org/r/940269