Unable to use interwiki Special:UserRights
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

Have userrights-interwiki
Go to https://meta.wikimedia.org/wiki/Special:UserRights/AntiCompositeNumber@enwiki (or any user at any wiki, other than metawiki)

What happens?:

[501ab252-6ddc-4957-b73d-8ce62a2c67ef] /wiki/Special:UserRights/AntiCompositeNumber@enwiki   TypeError: Argument 1 passed to MediaWiki\User\UserNameUtils::isTemp() must be of the type string, object given, called in /srv/mediawiki/php-1.41.0-wmf.18/includes/specials/SpecialUserRights.php on line 652

from /srv/mediawiki/php-1.41.0-wmf.18/includes/user/UserNameUtils.php(372)
#0 /srv/mediawiki/php-1.41.0-wmf.18/includes/specials/SpecialUserRights.php(652): MediaWiki\User\UserNameUtils->isTemp(UserRightsProxy)
#1 /srv/mediawiki/php-1.41.0-wmf.18/includes/specials/SpecialUserRights.php(174): MediaWiki\Specials\SpecialUserRights->fetchUser(string, boolean)
#2 /srv/mediawiki/php-1.41.0-wmf.18/includes/specialpage/SpecialPage.php(701): MediaWiki\Specials\SpecialUserRights->execute(string)
#3 /srv/mediawiki/php-1.41.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1563): SpecialPage->run(string)
#4 /srv/mediawiki/php-1.41.0-wmf.18/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.41.0-wmf.18/includes/MediaWiki.php(948): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.41.0-wmf.18/includes/MediaWiki.php(597): MediaWiki->main()
#7 /srv/mediawiki/php-1.41.0-wmf.18/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.41.0-wmf.18/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

What should have happened instead?:
it works

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This will prevent Stewards from effectively responding to abuse.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialUserRights: Check for username to be temporary	mediawiki/core	master	+2 -2
	SpecialUserRights: Check for username to be temporary	mediawiki/core	wmf/1.41.0-wmf.18	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	dancy	T340246 1.41.0-wmf.18 deployment blockers
Resolved	PRODUCTION ERROR	Zabe	T342322 Unable to use interwiki Special:UserRights
Resolved		• AGueyte	T340468 Throw an error from UserGroupManager::addUserToGroup if called on a temporary user

Event Timeline

AntiCompositeNumber created this task.Jul 20 2023, 2:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2023, 2:55 AM

Zppix subscribed.Jul 20 2023, 2:55 AM

I don't have a multi-wiki test set up, but looking at git log I'm guessing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935143 (bf3cc4628ad4289bfe6d74caf3c1e07535fe0c6a).

Zppix mentioned this in T340246: 1.41.0-wmf.18 deployment blockers.Jul 20 2023, 3:04 AM

JJMC89 added a project: Wikimedia-production-error.Jul 20 2023, 3:53 AM

JJMC89 changed the subtype of this task from "Bug Report" to "Production Error".

Zabe updated the task description. (Show Details)Jul 20 2023, 6:55 AM

Zabe subscribed.

Change 940043 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] SpecialUserRights: Check for username to be temporary

https://gerrit.wikimedia.org/r/940043

gerritbot added a project: Patch-For-Review.Jul 20 2023, 6:59 AM

JJMC89 added a project: Temporary accounts.Jul 20 2023, 7:02 AM

Xaosflux triaged this task as Unbreak Now! priority.Jul 20 2023, 8:54 AM

Xaosflux subscribed.

wasn't expecting it to work, but confirm this also fails if using the API:

INPUT:
https://meta.wikimedia.org/w/api.php?action=userrights&format=json&user=xaosflux%40testwiki&add=flood&expiry=1%20day&reason=test%20for%20%5B%5Bticket%3AT342322%5D%5D&token=REDACTED&formatversion=2

OUTPUT:
{

"error": {
    "code": "internal_api_error_TypeError",
    "info": "[8b245135-7c9a-4e65-874a-72c1330c209a] Caught exception of type TypeError",
    "errorclass": "TypeError"
},
"servedby": "mw1358"

}

• AGueyte subscribed.Jul 20 2023, 11:25 AM

thiemowmde added a subtask: T340468: Throw an error from UserGroupManager::addUserToGroup if called on a temporary user.Jul 20 2023, 11:32 AM

Dreamy_Jazz added a project: Anti-Harassment-Team.Jul 20 2023, 11:42 AM

Change 940126 had a related patch set uploaded (by Dreamy Jazz; author: Zabe):

[mediawiki/core@wmf/1.41.0-wmf.18] SpecialUserRights: Check for username to be temporary

https://gerrit.wikimedia.org/r/940126

Vituzzu subscribed.Jul 20 2023, 11:51 AM

Melos subscribed.Jul 20 2023, 11:51 AM

Change 940043 merged by jenkins-bot:

[mediawiki/core@master] SpecialUserRights: Check for username to be temporary

https://gerrit.wikimedia.org/r/940043

Dreamy_Jazz assigned this task to Zabe.Jul 20 2023, 12:10 PM

Change 940126 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.18] SpecialUserRights: Check for username to be temporary

https://gerrit.wikimedia.org/r/940126

Mentioned in SAL (#wikimedia-operations) [2023-07-20T12:12:13Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:940126|SpecialUserRights: Check for username to be temporary (T340468 T342322)]]

Thanks to Zabe for the fix and deploy. Apologies on behalf of me for not noticing this issue at the time I +2'd.

Mentioned in SAL (#wikimedia-operations) [2023-07-20T12:13:49Z] <zabe@deploy1002> zabe and dreamyjazz: Backport for [[gerrit:940126|SpecialUserRights: Check for username to be temporary (T340468 T342322)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-07-20T12:20:35Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:940126|SpecialUserRights: Check for username to be temporary (T340468 T342322)]] (duration: 08m 22s)