Page MenuHomePhabricator

Weird behavior when clicking on the name or the thumbnail of the file
Closed, ResolvedPublic

Description

After I've chosen files to be uploaded (or donated if you will) with UploadWizard I can click on any file to choose a different file. This is something I haven't seen before and feels not intuitive.

  1. What I would expect after clicking on a name would be to change the name of the file being uploaded.
  2. What I would expect after clicking on a thumbnail (which is not a thumbnail BTW and feels wrong too) would be to see the picture being uploaded (it works as expected later on).
  3. Remove shouldn't simply remove the file.

Note that I don't want push "upload" until the names are OK. If it is problematic then you should add a note that files are not uploaded yet and I can change their names later.

Also if you cannot display thumbnails I think you should show blank thumbnails but rather only show names of files.


Version: unspecified
Severity: enhancement

Details

Reference
bz32246

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:04 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz32246.
bzimport added a subscriber: Unknown Object (MLST).
Nux created this task.Nov 7 2011, 9:11 PM

neilk wrote:

If you click on the thumbnail you should get a zoomed-in version of the file. Are you sure that's what happens? If so, what browser and OS are you using?

Otherwise, this is known behavior -- I was sure there was a bug for this but now I can't find it. I agree that it's probably not good, but it's less urgent. You can still cancel if you want.

I agree we should fix it so you can alter the filename instead.

(In reply to comment #0)

After I've chosen files to be uploaded (or donated if you will) with
UploadWizard I can click on any file to choose a different file. This is
something I haven't seen before and feels not intuitive.

  1. What I would expect after clicking on a name would be to change the name of

the file being uploaded.

  1. What I would expect after clicking on a thumbnail (which is not a thumbnail

BTW and feels wrong too) would be to see the picture being uploaded (it works
as expected later on).

  1. Remove shouldn't simply remove the file.

Note that I don't want push "upload" until the names are OK. If it is
problematic then you should add a note that files are not uploaded yet and I
can change their names later.

Also if you cannot display thumbnails I think you should show blank thumbnails
but rather only show names of files.

Nux added a comment.Nov 8 2011, 8:18 AM

Hm... Yes, so if the thumbnail thing is not intentional then this is probably related to Bug 26072. I would still expect a different behavior when clicking on a name or at least you could a a tooltip (title) to explain what happens when you click on a name.

My setup:
Opera version: 11.52
Compilation: 1100
Platform: Win32
System: Windows 7
Opera/9.80 (Windows NT 6.1; U; pl) Presto/2.9.168 Version/11.52

Clicking on the name opens a file upload dialog, but although changing the file to upload does change the text displayed (Instead of "File1.jpg" I now see "File2.jpg") the thumbnail does not change.

drecodeam wrote:

Clicking on the name activates the hidden input element, and hence opens the upload file dialog. I have added a patch to fix this bug : https://gerrit.wikimedia.org/r/#change,4778.

Thanks for the patch... Tested and works. Now, hopefully someone will apply it.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:29 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM