Page MenuHomePhabricator

[mobile] Add link drawer cannot be minimized after a user interacts with drawer's controls
Open, Needs TriagePublicPRODUCTION ERROR

Description

Steps to replicate the issue (include links if applicable):

  • On mobile Homeppage select Add link structured task and go to a recommended article.
  • As a first action on a page, click on the pointing down arrow to minimize the drawer, so all article text will be accessible. The drawer will be minimized.
  • After that, expand the drawer and answer 'yes' or 'no', or use 'Next' controls.
  • Once any of the above controls has been used, it's not possible to minimize the drawer.

What should have happened instead?:

Clicking on the arrow down control (or somewhere in the text) should minimizes the drawer.

Screen Shot 2023-07-21 at 12.48.52 PM.png (856×652 px, 124 KB)
Screen Shot 2023-07-21 at 12.48.42 PM.png (920×670 px, 206 KB)

Software versionwmf.18

Other information

  • using Minerva skin (desktop) - the drawer won't be displayed. The Console has several warnings: ext.popups was loaded but everything is disabled and jQuery.Deferred exception: overlay.$el is undefined VeInitMwMobileArticleTarget
  • the drawer on Desktop behaves correctly - it can be minimized at any point in user workflow
  • the issue is reproducible in browser emulators and on a real device.
  • two JS exceptions are yield:
Uncaught TypeError: Cannot read properties of null (reading 'context')
    at <anonymous>:5:190
    at Object.fire (<anonymous>:755:816)
    at ve.init.mw.ArticleTarget.surfaceReady (<anonymous>:354:796)
    at ve.init.mw.MobileArticleTarget.surfaceReady (<anonymous>:41:992)
    at StructuredTaskArticleTarget.surfaceReady (load.php?lang=en&modules=ext.growthExperiments.StructuredTask&skin=minerva&version=3wlkg:20:259)
    at <anonymous>:996:749
Uncaught TypeError: Cannot read properties of null (reading 'getModel')
    at getRefNodes (<anonymous>:58:695)
    at <anonymous>:58:844
    at Object.fire (<anonymous>:755:816)
    at ve.init.mw.ArticleTarget.surfaceReady (<anonymous>:354:796)
    at ve.init.mw.MobileArticleTarget.surfaceReady (<anonymous>:41:992)
    at StructuredTaskArticleTarget.surfaceReady (load.php?lang=en&modules=ext.growthExperiments.StructuredTask&skin=minerva&version=3wlkg:20:259)
    at <anonymous>:996:749

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

I'm failing to reproduce the behavior @Etonkovidova is describing, not sure why yet, see also maybe related T336717#9081169. However when following the reproduce steps I do see two JS exceptions in the console which are worth investigating:

Uncaught TypeError: Cannot read properties of null (reading 'context')
Uncaught TypeError: Cannot read properties of null (reading 'getModel')

using Minerva skin (desktop) - the drawer won't be displayed. The Console has several warnings: ext.popups was loaded but everything is disabled and jQuery.Deferred exception: overlay.$el is undefined VeInitMwMobileArticleTarget

I can reproduce this and observe the exceptions, filed as T343904: Structured tasks don't work on desktop using Minerva skin.

Jdlrobson subscribed.

Came across this while triaging errors today due to our email alerts reporting more errors than normal. 1,440 errors in last 2 days.
These are occurring on the mobile site: https://logstash.wikimedia.org/goto/85621078368a1b02547c5691cfe77074

at getRefNodes  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.editCheck&skin=minerva&version=4cujo:3:481
at eval  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.editCheck&skin=minerva&version=4cujo:3:630
at Object.fire  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=mediawiki.base&skin=minerva&version=1qbws:4:699
at ve.init.mw.ArticleTarget.surfaceReady  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.articleTarget&skin=minerva&version=lbim2:10:461
at ve.init.mw.MobileArticleTarget.surfaceReady  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.mobileArticleTarget&skin=minerva&version=1m3hm:5:894
at StructuredTaskArticleTarget.surfaceReady  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.growthExperiments.StructuredTask&skin=minerva&version=7hn4s:25:362
at eval  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.mediawiki&skin=minerva&version=o7sol:24:181

This has either been fixed or the error has changed form. Can you confirm?

Screenshot 2025-03-20 at 3.03.18 PM.png (416×1 px, 80 KB)

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptMar 20 2025, 10:03 PM

This has either been fixed or the error has changed form. Can you confirm?

Screenshot 2025-03-20 at 3.03.18 PM.png (416×1 px, 80 KB)

Re-checked the issue and the Console errors:

Those errors might be unrelated to the issue?