Page MenuHomePhabricator

MobileFrontend image viewer doesn't set focus properly
Open, Stalled, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Click on an image on the mobile site
  • Press tab when the image viewer is open

What happens?:
The focus remains on the page content which isnt visible

What should have happened instead?:
The focus should be moved to the overlay, and the buttons should be accessible via tab

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

For newcomers
-This concerns the code in MobileFrontend - please setup MediaWIki with this extension

  • you will also need the Minerva skin installed
  • Run npm install && npm start in MobileFrontend before starting development.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Jdlrobson-WMF subscribed.

Freeing this up for someone else to work on. On long term we probably want to address the unification of the mobile and desktop media viewers before taking this on.

Izno added a subscriber: AyushShukla1807.

Change #1187968 had a related patch set uploaded (by Rehan_khan_78; author: Rehan_khan_78):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Move focus to image overlay and make buttons tabbable

https://gerrit.wikimedia.org/r/1187968

Change #1187968 abandoned by Rehan_khan_78:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Move focus to image overlay and make buttons tabbable

https://gerrit.wikimedia.org/r/1187968

Hi! I'm interested in working on this task. I have experience with JavaScript and the MERN stack. I've set up my Gerrit account and would like to contribute. Could someone guide me on how to get started with the MobileFrontend extension?

Hi, I'm Monica, a frontend developer interested in contributing to Wikimedia. I would like to work on this task as my first contribution. I am currently setting up MediaWiki with the Mobile Frontend extension and Minerva skin. I will update my progress soon. Please let me know if there are any guidelines I should follow.

Hi everyone! I'm Manish, a second-year CS student interested in contributing to MediaWiki for GSoC 2026.

I'd like to work on this task to fix the focus management in the MobileFrontend image viewer. This is an important accessibility issue, and I have experience with the following:

  • JavaScript and frontend development
  • Accessibility best practices
  • Open-source contribution workflows
  • Git and collaborative development

I'm currently setting up MediaWiki with the MobileFrontend extension and Minerva skin as outlined in the task. I understand the contribution process and am ready to follow the guidelines.

Please let me know if this task is available and if there are any specific steps or resources I should be aware of.

Thank you!

@VishakhaSahu05 @Monicadola42 @Manishhdev Hey y'all! Be sure to read the communication tips on the new developers page for MediaWiki. No need to ask for permission to work on a task, if you wish to work on it and it is unassigned, you may assign it to yourself and begin work!

Jdlrobson-WMF changed the task status from Open to Stalled.Tue, Mar 17, 5:03 PM
Jdlrobson-WMF lowered the priority of this task from Medium to Low.
Jdlrobson-WMF added a subscriber: egardner.

The Readers Growth team are currently considering retiring this feature. cc @egardner so we can think about accessibility in the new version. I suggest stalling this in the mean time.

Hi, I’d like to work on this task. I’m new to Wikimedia and excited to contribute. Could you please guide me on how to get started?

Change #1257992 had a related patch set uploaded (by Chandravaibhav03; author: Chandravaibhav03):

[mediawiki/extensions/MobileFrontend@master] Fix focus issue in MobileFrontend image viewer

https://gerrit.wikimedia.org/r/1257992

I have submitted a patch for this issue. Please review and let me know if any changes are needed.

Hi, I’d like to work on this task. I’m new to Wikimedia and excited to contribute. Could you please guide me on how to get started?

Hi @Chandravaibhav03 plesae see my comment above from Tuesday ({T342581#11720063}) we've stalled this ticket. Apologies for not removing the patch-welcome and good-first-task.

Note the description requests the focus on the overlay NOT the image, so this is a lot more complicated than initially thought.