When displaying a LTR fallback label in a RTL locale we should add the `dir` and `lang` attribute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	AAlhazwani-WMF
	Jul 25 2023, 2:51 PM

Project Tags

Referenced Files

	F41534713: image.png
	Nov 24 2023, 9:56 PM

	F37157061: CleanShot 2023-07-31 at 15.25.11@2x.png
	Jul 31 2023, 1:25 PM

	F37149455: CleanShot 2023-07-25 at 16.50.32@2x.png
	Jul 25 2023, 2:51 PM

	F37149454: CleanShot 2023-07-25 at 16.48.18@2x.png
	Jul 25 2023, 2:51 PM

Subscribers

AAlhazwani-WMF

Jdforrester-WMF

Description

In the example below the the degree sign is displayed in the wrong position.

CleanShot 2023-07-25 at 16.48.18@2x.png (3,072×1,386 px, 262 KB)

Adding the dir=ltr attribute fixes this issue.

We should also add the lang attribute given that we know in which language the text is being displayed.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Add dir and lang to HTML elements that differ from global uselang	Genoveva Galarza	mediawiki/extensions/WikiLambda	master	+929 -710

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	gengh	T363383 [24Q4] Wikifunctions's UX drives user behavior to increase linguistic accessibility
Resolved	gengh	T342661 When displaying a LTR fallback label in a RTL locale we should add the `dir` and `lang` attribute
Resolved	gengh	T296882 Consider whether to adopt Wikibase's {label,language} tuple (or replicate it) so we can show to the user what language a label is in inline

Event Timeline

AAlhazwani-WMF created this task.Jul 25 2023, 2:51 PM

Restricted Application added a project: I18n. · View Herald TranscriptJul 25 2023, 2:51 PM

Amire80 renamed this task from When displaying a LTR fallback label in a RLT locale we should add the `dir` and `lang` attribute to When displaying a LTR fallback label in a RTL locale we should add the `dir` and `lang` attribute.Jul 25 2023, 2:58 PM

another use case to keep in mind while working on this

CleanShot 2023-07-31 at 15.25.11@2x.png (756×816 px, 67 KB)

This probably needs us to do T296882 first.

Jdforrester-WMF triaged this task as Medium priority.Aug 3 2023, 4:51 PM

Jdforrester-WMF moved this task from To Triage to Needs Product/Design on the Abstract Wikipedia team board.

Jdforrester-WMF mentioned this in T343464: Text in other language should have lang and dir attribute.Aug 7 2023, 12:42 PM

Jdforrester-WMF mentioned this in T343460: Change the UX in Wikifunctions (and elsewhere?) to always(?) show the language used for each label when it's a fallback, with a call to action.Aug 7 2023, 6:18 PM

Winston_Sung moved this task from Untriaged to RTL on the I18n board.Aug 9 2023, 12:00 PM

A bug-report in Telegram provided this example, which I believe is part of this task. Adding here in case live-examples are useful:
Screenshot from https://www.wikifunctions.org/wiki/Z11938?uselang=pnb versus https://www.wikifunctions.org/wiki/Z11938?uselang=en
where the text should display as +e Python but shows as e Python+ in RTL.

Jdforrester-WMF added a subtask: T296882: Consider whether to adopt Wikibase's {label,language} tuple (or replicate it) so we can show to the user what language a label is in inline.Mar 7 2024, 4:36 PM

Jdforrester-WMF moved this task from Needs Product/Design to Upcoming Epics on the Abstract Wikipedia team board.

gengh claimed this task.May 14 2024, 3:32 PM

Jdforrester-WMF changed the task status from Open to In Progress.May 14 2024, 3:43 PM

Jdforrester-WMF added a parent task: T363383: [24Q4] Wikifunctions's UX drives user behavior to increase linguistic accessibility.

Jdforrester-WMF moved this task from Upcoming Epics to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (24Q4 (Apr–Jun)); removed: Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Change #1032417 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add dir and lang to HTML elements that differ from global uselang

https://gerrit.wikimedia.org/r/1032417

gerritbot added a project: Patch-For-Review.May 16 2024, 10:47 AM

Quiddity unsubscribed.May 16 2024, 5:31 PM

Jdforrester-WMF closed subtask T296882: Consider whether to adopt Wikibase's {label,language} tuple (or replicate it) so we can show to the user what language a label is in inline as Resolved.May 21 2024, 7:12 PM

Change #1032417 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add dir and lang to HTML elements that differ from global uselang

https://gerrit.wikimedia.org/r/1032417

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 22 2024, 7:30 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2024, 7:31 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 30 2024, 1:31 PM

Jdforrester-WMF closed this task as Resolved.May 30 2024, 1:33 PM

Jdforrester-WMF added projects: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), WikiLambda Front-end.

When displaying a LTR fallback label in a RTL locale we should add the `dir` and `lang` attributeClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

When displaying a LTR fallback label in a RTL locale we should add the `dir` and `lang` attribute
Closed, ResolvedPublic
Actions

Related Objects
Search...