Page MenuHomePhabricator
Create Task
Maniphest T342687

Object editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. Go to https://wikifunctions.beta.wmflabs.org/wiki/Z10332?action=edit
  2. Click the About edit pencil
  3. Make a change to the "Labels" input
  4. Notice that the "Done" button goes live as expected; press it

Observed behavior:

  • The page-level "Publish" button stays disabled

Expected behavior (Acceptance criteria):

  • The page-level "Publish" button should go live once you click "Done"

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Function impl marked dirty when labels changemediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+11 -2
Function impl marked dirty when labels changemediawiki/extensions/WikiLambdamaster+11 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jul 25 2023, 6:25 PM
Jdforrester-WMF renamed this task from Objet editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do to Object editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do.Jul 26 2023, 1:23 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.Jul 27 2023, 4:55 PM
SDunlap changed the task status from Open to In Progress.Jul 28 2023, 5:33 PM
SDunlap claimed this task.
gerritbot added a comment.Jul 28 2023, 7:39 PM

Change 942705 had a related patch set uploaded (by Stef Dunlap; author: Stef Dunlap):

[mediawiki/extensions/WikiLambda@master] Function impl marked dirty when labels change

https://gerrit.wikimedia.org/r/942705

gerritbot added a project: Patch-For-Review.Jul 28 2023, 7:39 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.Jul 28 2023, 8:07 PM
gerritbot added a comment.Jul 31 2023, 9:12 AM

Change 942705 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Function impl marked dirty when labels change

https://gerrit.wikimedia.org/r/942705

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 9:31 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 10:00 AM
gerritbot added a comment.Jul 31 2023, 10:16 AM

Change 942735 had a related patch set uploaded (by Jforrester; author: Stef Dunlap):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Function impl marked dirty when labels change

https://gerrit.wikimedia.org/r/942735

gerritbot added a project: Patch-For-Review.Jul 31 2023, 10:16 AM
Jdforrester-WMF moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.Jul 31 2023, 10:24 AM
gerritbot added a comment.Jul 31 2023, 12:19 PM

Change 942735 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Function impl marked dirty when labels change

https://gerrit.wikimedia.org/r/942735

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 12:31 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 1:00 PM
Stashbot mentioned this in T342901: MediaWiki\Extension\WikiLambda\ZErrorException: Not wellformed.Jul 31 2023, 1:13 PM
Stashbot mentioned this in T343006: Internal error when viewing /view/en/Special:WhatLinksHere.
Stashbot mentioned this in T343041: Links from wikitext to Objects should go to the /view/[lang]/ path not /wiki/.

Mentioned in SAL (#wikimedia-operations) [2023-07-31T13:13:02Z] <James_F> WikiLambda backport verified for T342891 T342687 T341500 T343006 T342901 and T343041

Stashbot mentioned this in T342891: Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present.Jul 31 2023, 1:13 PM
Stashbot mentioned this in T341500: Implement UX to select natural language one reads and edits Wikifunctions.
DVrandecic closed this task as Resolved.Aug 1 2023, 3:23 AM
DVrandecic subscribed.

Yep, works now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits