The temporary feature flag added in T341844 should be removed, so the feature defaults to enabled for all users (with the removal of the "This is a temporary feature flag." comment).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Enable edit recovery by default | mediawiki/core | master | +6 -3 |
If it remains, should the default value be true or false?
This task is currently stalled awaiting deployment to all wikis.
Note that there is now a user preference (which currently defaults to off), so there's less risk with removing the feature flag.
Making it false by default may make users installing MediaWiki unaware of such feature, which would be a bad idea.
Also other than this feature mark we have another way to disable this feature. Instead we can check whether it is enabled by checking whether $wgEditRecoveryExpiry is 0
It sounds like we'll probably remove the feature flag, once it's enabled on all Wikimedia wikis.
Also other than this feature mark we have another way to disable this feature. Instead we can check whether it is enabled by checking whether expire is 0
I'm not sure I understand which expire you're refering to. Do you mean that we can check whether there's any edit recovery data stored and expired? I think that's probably too late, because to do that we'd have to load Edit Recovery already and if the feature or preference is disabled then we wouldn't want anything to load at all.
What I mean: If we set $wgEditRecoveryExpiry to 0, we effectively disabled edit recovery. So there is a way to disable without introducing another setting.
I will support removing this feature flag.
What I mean: If we set $wgEditRecoveryExpiry to 0, we effectively disabled edit recovery. So there is a way to disable without introducing another setting.
Oh yes, that's a good point (and sorry, it's obvious now what you meant!).
Shouldn’t it just be documented as removed, similarly to e.g. $wgParserEnableLegacyHeadingDOM (which was also a feature flag)?
- Set to true in core.
Do you plan to do this in 1.45 (to be branched off in a week or two), or will it only happen in 1.46? The task should be tagged with MW-1.45-release or MW-1.46-release accordingly.
Change #1198668 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/core@master] Enable edit recovery by default
Yes, true, it's not correct to delete the manual page.
I've made a patch to change the default value to true.
You’re welcome.
I took a look at the MVP Scope of the Edit Recovery board, and it contains five open tasks. Are you sure this feature is ready to be enabled by default in 1.45?
Good point. Perhaps this needs more time than I've got right now. I'll postpone it for the time being.
(boldly rm'ing MW-1.45-release tag per the above comment; feel free to re-add if applicable!)