Special:UserRights has an interwiki mode, in which it allows users to change rights on a different wiki than they access the wiki on. This is a critical workflow in Wikimedia environemnt, as it is used by Stewards to self-promote themselves to other roles in case a quick response from them is needed.

Unfortunately, this functionality of Special:UserRights was broken two weeks in a row (T342747, T342322). This definitely signals we should test this functionality in CI, to decrease the chance of similar breakages happening in the future. Quoting related comments from T342747:

In T342747#9044464, @Urbanecm wrote:
In T342747#9044173, @Jdforrester-WMF wrote:

We apparently need better tests for interwiki Special:Userrights, as this is the second week in a row in which this feature of Special:Userrights caused a train blocker.

Interwiki Userrights means CentralAuth [...]

Not necessarily. AFAIK we only need to have two MediaWiki databases provisioned while CI runs our (integration) tests and the following three lines in LocalSettings.php:
$wgGroupPermissions['bureaucrat']['userrights-interwiki'] = true;
$wgLocalDatabases = ['awiki', 'bwiki'];
$wgConf->wikis = $wgLocalDatabases;
This should be sufficient to enable the interwiki functionality of Special:Userrights (this works locally in MediaWiki-Docker, w/o CentralAuth installed). From there, it should be fairly trivial to test it (at least sufficiently enough to avoid "it throws a fatal" kind of errors).

I haven't examined closely how CI works in our setup, but plugging in a database clonning sequence after install.php runs seems fairly trivial. We should probably ensure the second database resets itself in a similar way like the main test database does (which is definitely less trivial), but we shouldn't need to plug CentralAuth in.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Provide a secondary database	integration/quibble	master	+48 -4
	SpecialUserRightsTest: Add basic coverage for interwiki functionality	mediawiki/core	master	+70 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T379925 Add support for multi-DB testing to MediaWiki
		Open		None	T342763 Add testing for Special:UserRights's interwiki mode

Event Timeline

Urbanecm created this task.Jul 26 2023, 1:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2023, 1:17 PM

Urbanecm mentioned this in T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki'.Jul 26 2023, 1:18 PM

Novem_Linguae subscribed.Jul 26 2023, 1:41 PM

Moving task out of Continuous-Integration-Config (which is for the Jenkins/Zuul configs) in favor of MediaWiki-Core-Tests since Special:UserRights is part of MediaWiki core :)

Izno removed a project: MediaWiki-Special-pages.Aug 2 2023, 9:31 PM

In T342763#9050431, @hashar wrote:

Moving task out of Continuous-Integration-Config (which is for the Jenkins/Zuul configs) in favor of MediaWiki-Core-Tests since Special:UserRights is part of MediaWiki core :)

Thanks, but I think we would need some Jenkins changes to make introducing those tests possible (namely, figure a way how to have two installed MediaWiki databases). Or is that possible from the core end of things, without touching CI config?

We have (yet another) critical Userrights-related issue: T344391: Interwiki user rights changes not being logged correctly.

Change 949986 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[integration/quibble@master] Provide a secondary database

https://gerrit.wikimedia.org/r/949986

gerritbot added a project: Patch-For-Review.Aug 17 2023, 2:48 PM

I didn't manage to run Quibble locally (README advises to docker build --tag quibble ., but there is no Dockerfile in the repository since https://gerrit.wikimedia.org/r/c/integration/quibble/+/757888's by @kostajh), so the patch above is untested. But, hopefully the idea of clonning a fully provisioned database is clear from the code.

Next step: Figure out how to run Quibble and test the patch.

Change 950029 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] SpecialUserRightsTest: Add basic coverage for interwiki functionality

https://gerrit.wikimedia.org/r/950029

Involves a Quibble change (to provision two databases per wiki). Patch uploaded, needs CR.

TheresNoTime subscribed.Aug 18 2023, 12:53 PM

Change 950029 merged by jenkins-bot:

[mediawiki/core@master] SpecialUserRightsTest: Add basic coverage for interwiki functionality

https://gerrit.wikimedia.org/r/950029

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 12 2023, 11:00 AM

hashar unsubscribed.Jan 3 2024, 2:18 PM

Change 949986 abandoned by Hashar:

[integration/quibble@master] Provide a secondary database

Reason:

https://gerrit.wikimedia.org/r/949986

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 10:30 AM

Michael subscribed.Nov 14 2024, 3:24 PM

Urbanecm added a parent task: T379925: Add support for multi-DB testing to MediaWiki.Nov 14 2024, 3:25 PM

Urbanecm removed a project: Quibble.Nov 14 2024, 3:44 PM

hashar mentioned this in T379925: Add support for multi-DB testing to MediaWiki.Nov 27 2024, 3:58 PM

Special:UserRights in interwiki mode broke again in the last two trains:

Can we somehow increase the urgency of this? I believe this is mostly related to PSI efforts, given the most significant impact of the breakage is "Stewards are unable to perform time-sensitive user rights manipulation". I'm tagging the team's tag.

Also, FYI @EMill-WMF for awareness.

mszwarc subscribed.Fri, May 22, 7:57 AM

Add testing for Special:UserRights's interwiki modeOpen, Needs TriagePublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Add testing for Special:UserRights's interwiki mode
Open, Needs TriagePublic
Actions

Related Objects
Search...