Page MenuHomePhabricator

Drop cur table in production
Open, MediumPublic

Description

This table supposed to be dropped in 2008 (it's 2025 right now). It was being referenced in text table blobs but I thinkTM I fixed all of those. We can check if they are not getting any reads, take a long-standing backup, and then drop them

Event Timeline

The support in code is not relevant here. The actual data has been migrated.

Ladsgroup triaged this task as Medium priority.Aug 1 2023, 10:00 AM
Ladsgroup moved this task from Triage to Blocked on the DBA board.

Blocked until I confirm we have migrated as much as possible.

While I was running the moveToExternal.php, I found out we have a lot of stuff in text table everywhere. Sigh

root@dbstore1003:/srv/sqldata.s5/enwikivoyage# ls -Ssh | head
total 30G
 26G text.ibd
745M revision.ibd
609M logging.ibd
269M content.ibd
253M user.ibd
229M comment.ibd
185M actor.ibd
185M slots.ibd
169M pagelinks.ibd

After optimize:

root@dbstore1003:/srv/sqldata.s5/enwikivoyage# ls -Ssh | head
total 4.1G
745M revision.ibd
609M logging.ibd
269M content.ibd
253M user.ibd
229M comment.ibd
185M actor.ibd
185M slots.ibd
176M text.ibd
169M pagelinks.ibd

optimized enwikivoyage.text in all replicas.

What's the status of this? What's pending/next?

I'm waiting for the wikimedia dropbox to be in place before moving towards deletion (and keeping an archive).

I ran moveToExternal.php to make sure every case of direct calls to cur is fixed. Query says there are some left but I'm fairly certain they are not fixable and should just mark those revs as corrupted and be done with it. I will double check before drop though.

I'm about to drop the cur table on wikis where there is no reference to stub objects in text table (we can check that since text table is mostly empty now!). To be safe, I'm skipping any wiki that has even one reference to any sort of stub (most of them don't involve cur table, and the ones that do, the revision is mostly broken).

Most of the tables have been dropped. Only a few left.