Page MenuHomePhabricator
Create Task
Maniphest T342936

MobileFrontend drawer icon and MMV buttons are missing accessible labels
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
None
Authored By
bwang
Jul 27 2023, 11:00 PM
Tags
Referenced Files
F37854692: screenshot 94.png
Sep 29 2023, 9:17 PM
F37854691: screenshot 93.png
Sep 29 2023, 9:17 PM
F37854658: screenshot 92.png
Sep 29 2023, 9:17 PM
F37854657: screenshot 91.png
Sep 29 2023, 9:17 PM
F37748471: screenshot 77.png
Sep 22 2023, 2:01 AM
F37748470: screenshot 76.png
Sep 22 2023, 2:01 AM
F37748467: screenshot 73.png
Sep 22 2023, 2:01 AM
F37152494: Screenshot 2023-07-27 at 5.57.17 PM.png
Jul 27 2023, 11:00 PM
View All 10 Files
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
ovasileva

Description

Steps to replicate the issue (include links if applicable):
Inspect icon buttons from MobileFrontend

  • Expand/close button in the drawer
    Screenshot 2023-07-27 at 5.54.50 PM.png (1×2 px, 314 KB)
  • next and previous arrow buttons in image viewer
    Screenshot 2023-07-27 at 5.57.17 PM.png (228×1 px, 67 KB)

Looking in the code, it looks like the error icon button also doesnt have a label

What happens?:
They dont have labels

What should have happened instead?:
They should have sensible, descriptive labels

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T342936#9189598
2✅T342936#9189598

QA Results - Prod

ACStatusDetails
1✅T342936#9212468
2✅T342936#9212468

Details

SubjectRepoBranchLines +/-
Add label to drawer close iconmediawiki/extensions/MobileFrontendmaster+10 -6
Add titles for media viewer's "prev" and "next" buttonsmediawiki/extensions/MobileFrontendmaster+19 -7
Hide image overlay slider buttonsmediawiki/skins/MinervaNeuemaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

bwang created this task.Jul 27 2023, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2023, 11:00 PM
bwang merged a task: T342582: MobileFrontend image viewer buttons aren't labeled.Jul 27 2023, 11:01 PM
Jdlrobson triaged this task as Medium priority.Jul 28 2023, 6:43 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4); removed Web-Team-Backlog.
gerritbot added a comment.Jul 28 2023, 6:49 PM

Change 941863 had a related patch set uploaded (by Jdlrobson; author: 沈澄心):

[mediawiki/extensions/MobileFrontend@master] Add titles for media viewer's "prev" and "next" buttons

https://gerrit.wikimedia.org/r/941863

gerritbot added a project: Patch-For-Review.Jul 28 2023, 6:49 PM
gerritbot added a comment.Jul 31 2023, 3:51 PM

Change 943606 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Hide image overlay slider buttons

https://gerrit.wikimedia.org/r/943606

gerritbot added a comment.Jul 31 2023, 4:18 PM

Change 943606 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Hide image overlay slider buttons

https://gerrit.wikimedia.org/r/943606

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 5:00 PM
gerritbot added a comment.Jul 31 2023, 6:23 PM

Change 941863 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add titles for media viewer's "prev" and "next" buttons

https://gerrit.wikimedia.org/r/941863

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 6:29 PM
Jdlrobson edited projects, added patch-welcome, Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4).Aug 10 2023, 6:02 PM
ovasileva set the point value for this task to 2.Aug 24 2023, 5:41 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 24 2023, 5:44 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5).Sep 5 2023, 5:25 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 11 2023, 2:09 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 12 2023, 4:42 PM
bwang claimed this task.Sep 19 2023, 5:28 PM
bwang moved this task from Incoming to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
gerritbot added a comment.Sep 19 2023, 7:45 PM

Change 959044 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Add label to drawer close icon

https://gerrit.wikimedia.org/r/959044

gerritbot added a project: Patch-For-Review.Sep 19 2023, 7:45 PM
Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 19 2023, 9:25 PM
gerritbot added a comment.Sep 21 2023, 3:32 PM

Change 959792 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Update section toggle indicator to be an icon not a button

https://gerrit.wikimedia.org/r/959792

bwang removed bwang as the assignee of this task.Sep 21 2023, 4:05 PM
bwang moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson moved this task from Code Review to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 21 2023, 4:35 PM
bwang moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 21 2023, 4:51 PM
Jdlrobson moved this task from Code Review to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 21 2023, 4:57 PM
Jdlrobson claimed this task.Sep 21 2023, 5:01 PM
Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 21 2023, 5:05 PM
gerritbot added a comment.Sep 21 2023, 6:29 PM

Change 959792 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Update section toggle indicator to be an icon not a button

https://gerrit.wikimedia.org/r/959792

gerritbot added a comment.Sep 21 2023, 6:38 PM

Change 959792 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Update section toggle indicator to be an icon not a button

https://gerrit.wikimedia.org/r/959792

gerritbot added a comment.Sep 21 2023, 7:11 PM

Change 959044 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add label to drawer close icon

https://gerrit.wikimedia.org/r/959044

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Sep 21 2023, 8:00 PM
Jdlrobson renamed this task from Multiple MobileFrontend icon buttons missing accessible labels to Multiple MobileFrontend drawer icon button missing accessible labels.Sep 21 2023, 11:10 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

Given it's EOD Thursday I've split out the remaining work into T347119.

Jdlrobson renamed this task from Multiple MobileFrontend drawer icon button missing accessible labels to MobileFrontend drawer icon and MMV buttons are missing accessible labels.Sep 21 2023, 11:11 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.
Jdlrobson added a subscriber: Jdlrobson.
Edtadros removed Edtadros as the assignee of this task.Sep 22 2023, 2:01 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Inspect icon buttons from MobileFrontend.
They should have sensible, descriptive labels

✅ AC1: Expand/close button in the drawer

screenshot 73.png (1×1 px, 419 KB)

✅ AC2: Next and previous arrow buttons in image viewer
screenshot 76.png (1×1 px, 1 MB)

screenshot 77.png (1×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Sep 22 2023, 2:02 AM
Jdlrobson assigned this task to ovasileva.Sep 22 2023, 10:56 PM
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 25 2023, 3:09 PM

Looks good!

Jdlrobson reassigned this task from ovasileva to Edtadros.Sep 26 2023, 4:37 PM
Jdlrobson added a subscriber: ovasileva.
Edtadros closed this task as Resolved.Sep 29 2023, 9:17 PM
Edtadros removed Edtadros as the assignee of this task.
Edtadros added a project: Verified.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Inspect icon buttons from MobileFrontend.
They should have sensible, descriptive labels

✅ AC1: Expand/close button in the drawer

screenshot 91.png (1×1 px, 384 KB)
screenshot 92.png (1×1 px, 235 KB)

✅ AC2: Next and previous arrow buttons in image viewer

screenshot 93.png (1×1 px, 956 KB)
screenshot 94.png (1×1 px, 986 KB)
Edtadros updated the task description. (Show Details)Sep 29 2023, 9:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL