Author: neilk
Description:
Some combination of parameters causes this error in production:
Call to undefined method LocalFile::getFileKey() in /usr/local/apache/common-local/php-1.18/includes/api/ApiUpload.php on line 155
Aaron Schulz investigated the backtrace in production, and it goes something like this:
PHP Notice: Upload stash bug:
- UploadFromStash.php line 105 calls wfBacktrace()
- ApiUpload.php line 150 calls UploadFromStash->stashFile()
- ApiUpload.php line 174 calls ApiUpload->performStash()
- ApiUpload.php line 97 calls ApiUpload->dieRecoverableError()
- ApiMain.php line 692 calls ApiUpload->execute()
- ApiMain.php line 358 calls ApiMain->executeAction()
- ApiMain.php line 342 calls ApiMain->executeActionWithErrorHandling()
Not sure exactly what the params are but it's as if we have parameters corresponding to a regular upload (like 'file') *and* an UploadFromStash ('filekey'). But that's supposed to be impossible, given the API restrictions.
Version: 1.18.x
Severity: normal