Page MenuHomePhabricator
Create Task
Maniphest T343178

[wmf.20 - mobile] closing New Impact drawer closes Impact overlay
Closed, ResolvedPublicBUG REPORT
Actions

Description

Notes:

Steps to replicate the issue (include links if applicable):

  • Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Homepage and click arrows next to "My impact". "Suggested Edits"
  • You may use new mw.Api().saveOptions( { 'growthexperiments-tour-newimpact-discovery': 0 } ); to bring up the Updated design info drawer.
  • Click on "Got it" on the drawer - the overlay with (Impact module) will close and a user is returned to Homepage.

What should have happened instead?:

  • the Updated design info drawer will close
  • user stays on the Impact overlay

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Homepage mobile: avoid navigate away from the impact overlaymediawiki/extensions/GrowthExperimentsmaster+3 -8
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Aug 1 2023, 12:42 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 1 2023, 12:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from [betalabs - mobile] to [betalabs - mobile] closing New Impact drawer closes Impact overlay.Aug 1 2023, 12:43 AM
Etonkovidova updated the task description. (Show Details)Aug 1 2023, 12:54 AM
Etonkovidova updated the task description. (Show Details)Aug 1 2023, 1:00 AM
Urbanecm_WMF renamed this task from [betalabs - mobile] closing New Impact drawer closes Impact overlay to [wmf.20 - mobile] closing New Impact drawer closes Impact overlay.Aug 1 2023, 9:19 AM
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF edited projects, added Regression, Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Seems to be present since wmf.20. Moving to sprint as a current Regression.

Urbanecm_WMF triaged this task as High priority.Aug 1 2023, 9:21 AM
Urbanecm_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs claimed this task.Aug 7 2023, 10:35 AM
Sgs moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs added a comment.EditedAug 8 2023, 9:45 AM
In T343178#9058151, @Urbanecm_WMF wrote:

Seems to be present since wmf.20. Moving to sprint as a current Regression.

I am not sure if this is a regression or there's a race condition between the browser handling a MobileFrontend Anchor with an href="#" and some ad-hoc code in a click handler trying to prevent that navigation.

Since it was already marked as fixme/odd I'm updating the link to the impact view router path which shouldn't cause any navigation. For mobile details renders without the overlay the path addition should not do any harm so no investing in that scenario because of T264992: Remove mobile-details mode from Special:Homepage. Worth mentioning that the current code is producing a duplicated POST request for saving the user option.

gerritbot added a comment.Aug 8 2023, 9:45 AM

Change 946926 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Homepage mobile: avoid navigate away from the impact overlay

https://gerrit.wikimedia.org/r/946926

gerritbot added a project: Patch-For-Review.Aug 8 2023, 9:45 AM
Sgs changed the task status from Open to In Progress.Aug 8 2023, 9:45 AM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 9 2023, 9:27 AM
gerritbot added a comment.Aug 9 2023, 9:47 AM

Change 946926 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage mobile: avoid navigate away from the impact overlay

https://gerrit.wikimedia.org/r/946926

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 9 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 9 2023, 10:10 AM
Urbanecm_WMF changed the task status from In Progress to Open.Aug 9 2023, 11:50 AM
Etonkovidova closed this task as Resolved.Aug 20 2023, 11:03 AM

Checked on wmf.22 - the fix is in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits