Page MenuHomePhabricator

Radio: Make name prop required
Closed, ResolvedPublic1 Estimated Story Points

Description

The name prop is used for the name attribute of the radio input, which is required to tie a group of radios together. This prop should be required since the component doesn't really work without it.

This is technically a breaking change. I have reviewed all usage of CdxRadio in codesearch and found that all of them use the name prop already, so this should not affect any known users.


Acceptance criteria

  • Make the name prop of the Radio component required
  • Mark the commit as a breaking change and announce it as such when this change is released

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AnneT triaged this task as High priority.Aug 1 2023, 12:27 PM
AnneT set the point value for this task to 1.
AnneT added a project: Codex 1.0.
AnneT moved this task from Inbox to Up Next on the Design-System-Team board.

@CCiufo-WMF This came out of this spike and is a one-line change that we should definitely do pre-1.0 since it is making a currely optional prop required. I've triaged it as high but please feel free to change that!

Change 945824 had a related patch set uploaded (by Didier-ds; author: Didier-ds):

[design/codex@main] [BREAKING CHANGE] Radio: Made the name prop of the Radio component required

https://gerrit.wikimedia.org/r/945824

CCiufo-WMF changed the task status from Open to In Progress.Aug 4 2023, 7:22 PM

Change 945824 merged by jenkins-bot:

[design/codex@main] [BREAKING CHANGE] Radio: Made the name prop of the Radio component required

https://gerrit.wikimedia.org/r/945824

Change 953351 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351

Change 953351 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351