Maniphest T343218

Make use of ES6 in Maps(Kartographer) Extension
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MareikeHeuerWMDE
	Aug 1 2023, 12:34 PM

Tags

Referenced Files

None

Subscribers

MareikeHeuerWMDE

Description

This ticket is 'stalled' until T342864: Replace jsduck with JSDoc3 in Kartographer is done.

The support for ES5 only browsers has been dropped with T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) we can upgrade the code used in our projects to ES6,

This can mainly be done by bumping the eslint rule set applied on the source from wikimedia/client-es5 to wikimedia/client-es6 in the .eslintrc.json file. Then the linters can run with autofixes.
It's also advisable to bump the core requirement in the extensions.json to at least "MediaWiki": ">= 1.41.0" if the code changes are user facing.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Convert Maps(Kartographer) extension to ES6	mediawiki/extensions/Kartographer	master	+422 -439

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T334853 Clean up JS code now that we can use ES6 rather than ES5 across all Wikimedia deployed codebases
		Resolved		None	T343218 Make use of ES6 in Maps(Kartographer) Extension
		Resolved		None	T342864 Replace jsduck with JSDoc3 in Kartographer

Event Timeline

MareikeHeuerWMDE created this task.Aug 1 2023, 12:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2023, 12:34 PM

MareikeHeuerWMDE changed the task status from Open to Stalled.Aug 1 2023, 12:40 PM

MareikeHeuerWMDE updated the task description. (Show Details)

WMDE-Fisch mentioned this in T339323: Make use of ES6 in WMDE-TechWish projects.Aug 7 2023, 10:12 AM

WMDE-Fisch added a subtask: T342864: Replace jsduck with JSDoc3 in Kartographer.

WMDE-Fisch added a parent task: T334853: Clean up JS code now that we can use ES6 rather than ES5 across all Wikimedia deployed codebases.

JSDuck was replaced with JSDoc so this ticket can move forward now.

WMDE-Fisch moved this task from Watching / Epic to Backlog on the WMDE-TechWish-Maintenance-2023 board.Aug 15 2023, 8:56 AM

Change 940185 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Kartographer@master] Convert Maps(Kartographer) extension to ES6

https://gerrit.wikimedia.org/r/940185

gerritbot added a project: Patch-For-Review.Aug 15 2023, 12:30 PM

Change 940185 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Convert Maps(Kartographer) extension to ES6

https://gerrit.wikimedia.org/r/940185

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2023, 1:31 PM

WMDE-Fisch moved this task from Backlog to Done on the WMDE-TechWish-Maintenance-2023 board.Aug 16 2023, 6:40 AM

WMDE-Fisch closed this task as Resolved.Aug 16 2023, 8:32 AM

WMDE-Fisch closed subtask T342864: Replace jsduck with JSDoc3 in Kartographer as Resolved.