Cite's use of dynamic Parser::$extCite should be rewritten/removed
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Aug 1 2023, 2:31 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

cscott

Description

There's no guarantee on identity on the specific parser objects used during article pass. With both async fragment rendering as well as the Parsoid/Parser migration (which may cause different parts of the page to be variously rendered using the new Parsoid or legacy parser), the actual Parser objects seen may be different for different instances of an extension tag on the same page.

When PHP 8.2 disallowed dynamic property creation, the following error was given (T324901):

Deprecated: Creation of dynamic property Parser::$extCite is deprecated in /var/www/wiki/mediawiki/extensions/Cite/src/Hooks/CiteParserTagHooks.php on line 94

This was "fixed" by allowing dynamic properties on the Parser class, but this fix should eventually be reverted once the underlying usage in Cite is removed.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	parser: Remove deprecated Parser::$extCite property	mediawiki/core	master	+0 -2
	Remove use of Parser::$extCite	mediawiki/extensions/Cite	master	+101 -56

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T343227 Remove #[AllowDynamicProperties] from Parser class
Open	None	T343230 Cite's use of dynamic Parser::$extCite should be rewritten/removed
Resolved	Reedy	T324901 Deprecated: Creation of dynamic property Parser::$extCite is deprecated in CiteParserTagHooks.php on line 94

Event Timeline

cscott created this task.Aug 1 2023, 2:31 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptAug 1 2023, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

cscott added a parent task: T343227: Remove #[AllowDynamicProperties] from Parser class.Aug 1 2023, 2:31 PM

cscott added a subtask: T324901: Deprecated: Creation of dynamic property Parser::$extCite is deprecated in CiteParserTagHooks.php on line 94.

MSantos moved this task from Needs Triage to Missing Functionality on the Parsoid board.Aug 3 2023, 2:24 PM

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Aug 3 2023, 2:27 PM

MSantos edited projects, added: Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed: Parsoid-Read-Views.

thiemowmde mentioned this in T351997: Identify approachable tasks on the Cite workboard.Nov 28 2023, 3:24 PM

thiemowmde mentioned this in T36589: Content of <references/> not shown when other parser extensions are active.Dec 4 2023, 8:58 AM

cscott mentioned this in T359887: Use alternative storage to store HashTables data currently stored in Parser.Apr 16 2024, 2:06 PM

cscott mentioned this in T362664: Remove dynamic Parser::$proofreadRenderingPages from Parser and ProofreadPage extension..

cscott mentioned this in T362693: Remove dynamic Parser::$mTemplatePath from Parser and LabeledSectionTransclusion extension..Apr 16 2024, 4:14 PM

Change #1191752 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cite@master] Remove use of Parser::$extCite

https://gerrit.wikimedia.org/r/1191752

gerritbot added a project: Patch-For-Review.Sep 26 2025, 7:35 PM

Change #1191752 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove use of Parser::$extCite

https://gerrit.wikimedia.org/r/1191752

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2025, 3:30 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 13 2025, 4:00 AM

The patch sets removes the need of a property on the Parser instance, it does not analyse or handle the possible impact on fragmentation parsing as part of the description:

There's no guarantee on identity on the specific parser objects used during article pass. With both async fragment rendering as well as the Parsoid/Parser migration (which may cause different parts of the page to be variously rendered using the new Parsoid or legacy parser), the actual Parser objects seen may be different for different instances of an extension tag on the same page.

It seems the Cite class holds state for parsing (like $inRefTag or $inReferencesGroup), not sure if that should be handled with this task or a new one.