@gonyeahialam can add the design images for this ticket? thanks!

In T343449#9066493, @ifried wrote:

@gonyeahialam can add the design images for this ticket? thanks!

Done

I just realized that this task is now in progress, and that its AC include the empty state when answers have already been aggregated. I'm sure I mentioned before that I had concerns with the prototype, but that I wasn't going to explain them in that meeting due to time constraints. This eventually fell off my radar, and I don't even remember exactly the concerns I had. However, I'm pretty sure that one of them is space -- in that view, half of the available horizontal space is taken up by a single-sentence message. This can already be an issue on desktop, because the table would shrink a lot. But on mobile it's even worse, and I believe the page would become very hard to browse. For these reasons, I wanted to ask if it would be possible to reposition the notice outside of the table area; it could maybe go below the table, or really anywhere else, as long as it doesn't eat up too much horizontal space. CC @gonyeahialam

In T343449#9120894, @Daimona wrote:

I just realized that this task is now in progress, and that its AC include the empty state when answers have already been aggregated. I'm sure I mentioned before that I had concerns with the prototype, but that I wasn't going to explain them in that meeting due to time constraints. This eventually fell off my radar, and I don't even remember exactly the concerns I had. However, I'm pretty sure that one of them is space -- in that view, half of the available horizontal space is taken up by a single-sentence message. This can already be an issue on desktop, because the table would shrink a lot. But on mobile it's even worse, and I believe the page would become very hard to browse. For these reasons, I wanted to ask if it would be possible to reposition the notice outside of the table area; it could maybe go below the table, or really anywhere else, as long as it doesn't eat up too much horizontal space. CC @gonyeahialam

I can explore other options for this.
What do you mean by the table will shrink? Wouldn't the table be scrollable horizontally?

In T343449#9128152, @gonyeahialam wrote:

What do you mean by the table will shrink? Wouldn't the table be scrollable horizontally?

Yes, it will be scrollable. But this notice wouldn't be part of the table, so that complicates things. I'm also still wondering if the additional, mostly empty whitespace could be inconvenient on small screens.

In T343449#9128340, @Daimona wrote:

In T343449#9128152, @gonyeahialam wrote:

What do you mean by the table will shrink? Wouldn't the table be scrollable horizontally?

Yes, it will be scrollable. But this notice wouldn't be part of the table, so that complicates things. I'm also still wondering if the additional, mostly empty whitespace could be inconvenient on small screens.

I am exploring this as an alternative though I haven't finalised it.

In T343449#9141156, @gonyeahialam wrote:

I would say the previous version is the better version. Why do you say it can't be part of the table? Is it a technical limitation?

It's not a technical limitation, it's the way it appears in the prototype. You have an area with information that is not labelled by table headers, and does not scroll with the rest of the table. You also have a right border on the email column. These imply that the text in question is not part of the table.

Change 951979 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add participants non PII answers on participants list tab

https://gerrit.wikimedia.org/r/951979

In T343449#9141168, @Daimona wrote:

It's not a technical limitation, it's the way it appears in the prototype. You have an area with information that is not labelled by table headers, and does not scroll with the rest of the table. You also have a right border on the email column. These imply that the text in question is not part of the table.

Even if it is not part of the table, can't it still scroll alongside the table?

Updated copy
"Individual participants’ responses have been deleted and the aggregated responses are available under Response statistics."
Updated alternative design 1
Pros & cons: More visible but clutters the header

Alternative design 2
Put the notice message in the tooltip instead. The default tooltip text is similar to the notice text. So after aggregation the tooltip message can change to this.
Pros & cons: Less visible but cleaner

In T343449#9147256, @gonyeahialam wrote:

In T343449#9141168, @Daimona wrote:

It's not a technical limitation, it's the way it appears in the prototype. You have an area with information that is not labelled by table headers, and does not scroll with the rest of the table. You also have a right border on the email column. These imply that the text in question is not part of the table.

Even if it is not part of the table, can't it still scroll alongside the table?

It probably can, but as I said above, it makes things more complex from a technical perspective.

I'm also curious: I thought the notice could also be displayed in the footer, either above or below the "X participants registered privately" text, but I don't see the footer in the options above, which I assume is intentional. What makes the footer unsuited for this notice?

In T343449#9147687, @Daimona wrote:

I'm also curious: I thought the notice could also be displayed in the footer, either above or below the "X participants registered privately" text, but I don't see the footer in the options above, which I assume is intentional. What makes the footer unsuited for this notice?

Yes, I considered that but I decided against it since we already have a text in the footer and didn't want to increase it. But looking at it again, it might be a good alternative. I just need to figure out the best way to handle the information that will be duplicated in the tooltip and the notice

@Daimona We would go with this option. Take note of the spacing between the table, the first notice, and the second.

In T343449#9169504, @gonyeahialam wrote:

@Daimona We would go with this option. Take note of the spacing between the table, the first notice, and the second.

Thanks! I've updated the AC.

Change 959838 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Return non PII answers on ListParticipants API

https://gerrit.wikimedia.org/r/959838

Change 959855 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Show non PII data on scrolling

https://gerrit.wikimedia.org/r/959855

Hi @gonyeahialam, we are having a conversation about how the height of the list of participants will look like, could please tell us which one do you prefer, we end up with 2 options, 70vh or 80vh, here are some screenshots, so you can see how they would look like?

70vh:

80vh:

@cmelo 80vh is good.

What is the difference between the 2 images under each of the vh options above?

Change 951979 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add participants non PII answers on participants list tab

https://gerrit.wikimedia.org/r/951979

Change 959838 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Return non PII answers on ListParticipants API

https://gerrit.wikimedia.org/r/959838

Change 966204 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add missing message parameter in ListParticipantsHandler

https://gerrit.wikimedia.org/r/966204

Change 959855 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show non PII data on scrolling

https://gerrit.wikimedia.org/r/959855

Change 966204 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add missing message parameter in ListParticipantsHandler

https://gerrit.wikimedia.org/r/966204

Change 967268 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add notice about deleted non pii data on event details

https://gerrit.wikimedia.org/r/967268

Change 967268 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add notice about deleted non pii data on event details

https://gerrit.wikimedia.org/r/967268

Acceptance criteria

• Given a user has answered non-pii questions
• ✅ Then their answers should be shown in columns on the participants tab
• 

• Given a user has not answered non-pii questions
• ✅ Then the columns should display "No response"
• 

• Given the user has answered non-pii questions
• When the individual user has answered more than 90 days ago
• ❓ Then the field should display "The participants responses have been aggregated and deleted"
  • I am not able to test this for 90 days, so am making a note to myself to come back and check this in betacluster on Jan 29th. Follow up task to do this T350213.

• Given the event has ended
• ✅ The non-pii columns should be hidden and a message should be displayed to explain that the data has been aggregated and deleted
  • non pii columns are hidden and message correctly displays below the table
    

• ❌ Documentation of the List the participants of an event endpoint should be updated to mention that answers to non-PII questions are included in the response, if the user making the request is allowed to see them.
  • Endpoint docs still need to be updated

Documentation of the List the participants of an event endpoint updated.