Page MenuHomePhabricator

Change mechanism for altering links to Objects to not cache based on user page, and work with Parsoid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to a page with a link to a ZObject, for example https://www.wikifunctions.org/wiki/User:Msz2001/sandbox
  • See what does it link to (e.g. /view/pl/Z10000)
  • If it happens that the link leads to your language version:
    • Change your interface language
    • See that the link target doesn't change (e.g. links to PL even though you have English set)
  • Purge the page
  • See that the link target is now your interface language

What happens?:
The link targets are stored in a cache that's common to all users. The language code that's embedded in the /view/LANG/Z10000 link is determined for the user who invoked a purge and then it's reused for other people, even if they have other language set.

UPDATE: It affects both the target page and the link label when it's specified in a form like [[Z10000]].

What should have happened instead?:
Everyone should see a link that leads to a page in their own language.

Software version (skip for WMF-hosted wikis like Wikipedia): Wikifunctions

Other information (browser name/version, screenshots, etc.):

Event Timeline

Jdforrester-WMF renamed this task from Links to objects remember language of user who recently purged the page to Change mechanism for altering links to Objects to not cache based on user page, and work with Parsoid.Mar 7 2024, 4:43 PM
Jdforrester-WMF added a project: WikiLambda.

Change #1067394 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Drop onHtmlPageLinkRendererEnd, incompatible with Parsoid

https://gerrit.wikimedia.org/r/1067394

DSantamaria changed the task status from Open to In Progress.Jan 31 2025, 11:51 AM
Jdforrester-WMF changed the task status from In Progress to Stalled.Jan 31 2025, 6:07 PM

Needs product input still, sadly.

Jdforrester-WMF changed the task status from Stalled to Open.Feb 24 2025, 9:29 PM

Announced and now in CR.

DSantamaria changed the task status from Open to In Progress.Feb 26 2025, 6:19 AM

Change #1067394 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Switch onHtmlPageLinkRendererEnd to only run on Special pages, incompatible with Parsoid

https://gerrit.wikimedia.org/r/1067394