Page MenuHomePhabricator

Add test to verify that tests in the Database group actually use the database
Open, Needs TriagePublic

Description

Related to T155147, it would be nice to have some automatic check that tests in the Database group actually use the database. I'm not sure how easy this would be to implement though. Firstly because said checks would have to be skipped when at least one test case in the class was skipped (is this something we can determine?). And secondly because "using the database" could mean many different things and it might prove challenging to install some sort of observer for all possible DB usages.

Event Timeline

The TransactionProfiler would know about all done queries, but that does not help when the database is used to format queries, like calls to addQuotes

The TransactionProfiler would know about all done queries, but that does not help when the database is used to format queries, like calls to addQuotes

Indeed. I was also planning to introduce a new test-only query tracker for T342301, but as you say, it still wouldn't catch things like addQuotes, getInfinity, etc.