Page MenuHomePhabricator

Show a nicer error when a test does not use the connected function at top-level
Open, LowPublic

Description

Expected: Showing an error such as "The test does not involve the connected function".
Actual: Fails with {"Z1K1":"Z5","Z5K1":"Z507","Z5K2":{"Z1K1":{"Z1K1":"Z7","Z7K1":"Z885","Z885K1":"Z507"},"Z507K1":"Could not find argument Z10119K1."}} (even if the test will succeed if connected with Z10000)

See also: https://www.wikifunctions.org/view/en/Z10783,

NOTE: If a test case is A(B(x)), where A is implemented as C(D(x)), then A is directly called at top level, B is directly called at non-top level, and C and D are indirectly called.
URI percent decode (URI percent encode (🦄)) as a test ofTypeCurrentlyExpected
URI percent decodedirectly called at top levelwill workwill work
URI percent encodedirectly called at non-top levelwill not workwill work
Other function not mentionednot directly calledwill not workwill show a proper error message(*)

(*): It may be possible that a tested function is only indirectly called, but determining this is out of scope of this task (and it not well determined since one function may have multiple implementions and only some of which use a specific function).

Event Timeline

Bugreporter renamed this task from Confusing message when a test does not use the connected function to Confusing message when a test does not use the connected function at top-level.Aug 18 2023, 11:36 AM
Bugreporter updated the task description. (Show Details)
Bugreporter updated the task description. (Show Details)
Bugreporter added a subscriber: taavi.
Jdforrester-WMF renamed this task from Confusing message when a test does not use the connected function at top-level to Show a nicer error when a test does not use the connected function at top-level.Sep 14 2023, 5:25 PM
Jdforrester-WMF subscribed.

Fixing this properly would be T358370, but we can show a bespoke error for this circumstance before that work is done.