Page MenuHomePhabricator
Create Task
Maniphest T343654

The publish button should not be disabled when the initial content is given by oldid
Closed, ResolvedPublic
Actions

Description

Description

When opening an edit page directly loading old content with oldid, the loaded content is different from the current version.

However, the "Publish" button is only activated when there's a difference from the "initial content" loaded in the site state.

What to do when the initial content differs from the current persisted content?

Reproduce

Desired behavior/Acceptance criteria

  • ...

Devices and Design (URLs or screenshots)

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ability to directly 'publish' an old editmediawiki/extensions/WikiLambdamaster+13 -2
Customize query in gerrit

Event Timeline

Bugreporter created this task.Aug 6 2023, 10:38 AM
Jdforrester-WMF triaged this task as High priority.Aug 31 2023, 6:49 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: WikiLambda Front-end.
gengh subscribed.Sep 4 2023, 10:46 AM

I don't agree with marking this task as high priority/ready.

This is not a bug, but a different feature that has a number of side effects and needs careful consideration from design and engineering. I'd request we move this back to "Needs product/design".

gengh renamed this task from The publish button should not be disabled if the content is different from the current version to The publish button should not be disabled when the initial content is given by oldid.Sep 4 2023, 10:51 AM
gengh updated the task description. (Show Details)
gengh added a subscriber: Jdforrester-WMF.Sep 5 2023, 1:16 PM

After discussion with @Jdforrester-WMF we agreed to prioritize the button activation for now, and in the future add a message informing that the version seen is an old one.
We can add another condition to the Publish button activation that directly sets it as active if page is old version.

gerritbot added a comment.Feb 29 2024, 12:06 AM

Change 1007459 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Ability to directly 'publish' an old edit

https://gerrit.wikimedia.org/r/1007459

gerritbot added a project: Patch-For-Review.Feb 29 2024, 12:06 AM
99of9 subscribed.Mar 4 2024, 12:49 AM
gerritbot added a comment.Mar 5 2024, 2:17 PM

Change 1007459 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Ability to directly 'publish' an old edit

https://gerrit.wikimedia.org/r/1007459

Jdforrester-WMF changed the task status from Open to In Progress.Mar 5 2024, 2:18 PM
Jdforrester-WMF assigned this task to ecarg.
Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2024, 2:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 5 2024, 6:01 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Mar 13 2024, 8:16 PM
Jdforrester-WMF closed this task as Resolved.Mar 20 2024, 12:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits