Page MenuHomePhabricator

Patroller Tasks: main "List of edits" screen
Closed, ResolvedPublic

Assigned To
Authored By
Dbrant
Aug 8 2023, 5:33 PM
Referenced Files
F37646871: Group 5551.png
Sep 1 2023, 6:08 PM
F37646869: Group 5552.png
Sep 1 2023, 6:08 PM
F37643200: Usermenu.png
Aug 30 2023, 7:11 PM
F37643198: app bar.png
Aug 30 2023, 7:11 PM
F37643196: List of edits.png
Aug 30 2023, 7:11 PM
F37160426: Card open.png
Aug 22 2023, 11:04 PM
F37160497: App bar menu.png
Aug 22 2023, 11:04 PM
F37160423: List of edits.png
Aug 22 2023, 11:04 PM

Description

This is for building the activity that contains the list of recent edits for patrolling. It will be reachable through the "Suggested Edits -> Edit patrol" task.

Some rough architectural notes:

  • Can be modeled on one of our existing list-type screens, which are very similar.
  • Should ideally use a ViewModel with PagingSource.
  • Should make an API call to get recent edits, with filtering options to be plugged in from the Filters screen (built in a different task). While this is in the process of being built, no filtering is necessary.
  • "Search" functionality should be built into the Search bar at the top.

Support email Copy:

Subject:
Issue Report- Patroller Task Feature

Body:
I’ve encountered a problem with the Patroller Task Feature:

  • [Describe specific problem]

The behavior I would like to see is:

  • [Describe proposed solution]

[Screenshots or Links]


Designs (Figma)

Card in 'Suggested Edits'; List of edits

1. 'Edit patrol' card2. List of edits3. App bar menu4. Expand card
Suggested edits.png (360×720 px, 43 KB)
List of edits.png (360×720 px, 41 KB)
App bar menu.png (720×1,440 px, 109 KB)
Card open.png (360×720 px, 38 KB)
Card in 'Suggested Edits'; List of edits
  1. Edit patrol' card
  • ‘Edit patrol’ feature can be accessed through ‘Edits’ from the main tab bar:
    • The contributor will open the app and will be able to access ‘Edits’ from ‘Explore’, ‘Saved’, ‘Search’ or ‘More’,
    • The icon used in the ‘Edit patrol’ card is a new custom icon.
    • Copy: Edit patrol
    • Description: Review recent edits and determine whether they are constructive or not.
    • Button: Check icon ‘Review’
  1. List of edits
  • Tapping on the ‘Edit patrol’ card will bring the contributor to the ‘List of edits’ page.
  • The patroller will be able to search the edits via the search bar at the top of the page.
    • The patroller will be able to filter the edits by tapping on the filter icon (top right corner).
  • Page has cards displaying edit(s) on page.
    • Card includes:
    • Page title & time of edit ; edit summary ; tags ; username of editor ; bytes
  1. App bar menu
  • There is a notifications and more icon in the app bar. Tapping the more icon open a menu in top corner of page includes:
    • Problem with feature - Will take editor to the support email and pre-populate the subject line with ‘Patroller Edits Feature’.
    • Learn more - Will take editor to FAQ page
  1. Expand card
  • When an editor has made multiple edits on the same page a chevron will be displayed beside the time in the top corner of the card.
  • Tapping on the chevron will reveal the other contributions by the same contributor on that page.
  • All edits after the first edit by the same user on the same page will not include:
    • Page title ; username
  • Will include:
    • Time of edit; edit summary; tags; bytes

APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4176

Event Timeline

Dbrant triaged this task as Medium priority.Aug 8 2023, 5:33 PM

Hi @OTichonova and cc @Dbrant @JTannerWMF

  1. Expand card

Having multiple edits in a single card (the list item) will increase the complexity of implementation:

  • To build an expandable card will need an extra code to customize the library card view.
  • Need extra logic to arrange the edits if the edits on the same page were not on the same date.
  • Inconsistent list presentation between "Edit history", "Contributions", and "Watchlist".

Would it be possible to keep the list consistent with other lists that we already have in the app?

Hi @cooltey, how much time do you think it adds for implementation?
it would be great to be able to expand cards and see additional edits by the editor. It was a request from usability testing to allow patrollers to scan edits without having to go into 'Diff view'.

Hi @cooltey, how much time do you think it adds for implementation?
it would be great to be able to expand cards and see additional edits by the editor. It was a request from usability testing to allow patrollers to scan edits without having to go into 'Diff view'.

Hi @OTichonova
After doing research on the API of fetching recent edits, I noticed that grouping the edits by the same editor is prohibitively difficult:

Engineers planned to request at most 50 items per API call, and each API call may not contain the edits from the same user, which means we will need to process the card *after* fetching all the remaining data (for example 50 API calls or more) and put the edits into one specific card and will need to do it on every card. It will have a very high chance of causing UI latency while loading and also scrolling and will highly increase the loading amount of time.

Hi @cooltey, okay I see. Thank you so much for looking into this. Here are the updated designs without the chevron.

List of editsApp bar menuMenu: tapping on username
List of edits.png (720×1,440 px, 91 KB)
app bar.png (720×1,440 px, 111 KB)
Usermenu.png (360×720 px, 50 KB)

Hi @cooltey, great work! I have a couple minor things below.

3. App bar menuEmail
Group 5552.png (432×1,141 px, 138 KB)
Group 5551.png (861×960 px, 118 KB)

Hi @JTannerWMF

For the Email text, what do you think would be the best?

  1. Patroller Task vs. Patroller Tasks
  2. Should we update the name to Edit Patrol?

Please see @OTichonova 's review above.

Hi @cooltey! I spoke with Jazmin and she agreed to update Patroller Task -> Edit Patrol in the Subject and Body. Thank you!

Subject:
Issue Report- Edit Patrol Feature

Body:
I’ve encountered a problem with the Edit Patrol Feature:

cooltey updated the task description. (Show Details)

Hi @OTichonova

Please download the latest APK from the ticket description. Please note that the APK link is the same as the one in T343837