Page MenuHomePhabricator
Create Task
Maniphest T343886

Refactor generic Wikibase repo WebdriverIO tests from sync to async mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance criteria:

  • Refactor WebdriverIO tests (in repo/tests/selenium/) from sync to async mode.
  • Push code to Gerrit.
  • Browser tests are running on Gerrit

Details

SubjectRepoBranchLines +/-
Migrate item.js browser test from sync to asyncmediawiki/extensions/Wikibasemaster+125 -118
Start wdio sync to async migrationmediawiki/extensions/WikibaseREL1_40+37 -140
Migrate nonexisting.item.js browser test to asyncmediawiki/extensions/WikibaseREL1_40+24 -25
Improve browser tests after async migrationmediawiki/extensions/Wikibasemaster+6 -17
Use newly released wdio-wikibase v6mediawiki/extensions/Wikibasemaster+9 -8
Use `expect` instead of `assert` for browser testsmediawiki/extensions/Wikibasemaster+10 -18
Migrate readmode.references.js browser test from sync to asyncmediawiki/extensions/Wikibasemaster+24 -26
Migrate tainted-ref.js browser test from sync to asyncmediawiki/extensions/Wikibasemaster+66 -73
Migrate nonexisting.item.js browser test to asyncmediawiki/extensions/Wikibasemaster+27 -30
Start wdio sync to async migrationmediawiki/extensions/Wikibasemaster+35 -138
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT210726 Selenium framework maintenance
 OpenNoneT324685 Upgrade WebdriverIO to v8 in all repositories
 StalledNoneT324318 Update Wikibase code bases to WebdriverIO v8
 OpenNoneT293080 Refactor Wikibase WebdriverIO tests from sync to async mode
 OpenNoneT324766 Upgrade WebdriverIO to v8 in core
 ResolvedzeljkofilipinT332393 Selenium Jenkins jobs fail after updating @wdio npm packages to v8
 ResolvedRickiJay-WMDET347137 Update wdio-mediawiki to work with both WebdriverIO v7 and v8
 ResolvedRickiJay-WMDET347138 Update Code after patching WDIO-Mediawiki and WDIO-Wikibase
 OpenNoneT351747 Run Selenium tests locally using Firefox
ResolvedvaughnwaltersT355556 Webdriverio v7 fails locally with node v18 on macos
 ResolvedEBernhardsonT257525 Upgrade WebdriverIO in the CirrusSearch repository
 ResolvedEBernhardsonT289168 Upgrade WebdriverIO to v6 in CirrusSearch
 DeclinedNoneT255463 Upgrade WebdriverIO in the wikimedia/portals/deploy repository
 ResolvedhasharT259598 Tests fail in CI but the job is passing for the wikimedia/portals/deploy repository
 DeclinedNoneT289181 Selenium tests fail with `browser.getLogs is not a function`
OpenNoneT344682 Run Selenium tests targeting available local and remote testing environments
 OpenNoneT256239 Run Selenium tests targeting MediaWiki-Docker
 DuplicateNoneT256118 Create MediaWiki-Docker/WikibaseLexeme
 DeclinedNoneT256114 Create MediaWiki-Docker/Wikibase
 DeclinedNoneT257520 Error in setting up Wikibase locally
 ResolvedzeljkofilipinT290183 WikibaseLexeme Selenium tests fail when targeting wiki created by MediaWiki-Docker
 ResolvedzeljkofilipinT289853 Wikibase Selenium tests fail when targeting wiki created by MediaWiki-Docker
 ResolvedOsamaahmed17T293090 Fix MediaWiki-Docker/Extension/AbuseFilter
 OpenNoneT293092 Fix MediaWiki-Docker/Extension/AdvancedSearch
 OpenNoneT293093 Fix MediaWiki-Docker/Extension/CodeMirror
 ResolvedMhmohonaT293094 Fix MediaWiki-Docker/Extension/EntitySchema
 OpenNoneT293095 Fix MediaWiki-Docker/Extension/FileImporter
 ResolvedAghaSaad04T293096 Fix MediaWiki-Docker/Extension/Popups
 ResolvedMhmohonaT293098 Fix MediaWiki-Docker/Extension/RevisionSlider
 ResolvedLykarungiT293099 Fix MediaWiki-Docker/Extension/TwoColConflict
 ResolvedzeljkofilipinT293442 Create a MediaWiki account
 ResolvedzeljkofilipinT293746 Introduce yourself in MediaWiki-Docker topic in Zulip
 ResolvedzeljkofilipinT294110 TemplateWizard Selenium tests fail locally with 'Couldn't find plugin "junit" reporter'
 ResolvedzeljkofilipinT294131 TemplateWizard Selenium tests fail in CI with "element (".oo-ui-lookupElement-menu") still not displayed after 5000ms"
 OpenNoneT294643 Fix MediaWiki-Docker/Extension/CentralNotice
 OpenNoneT294644 Fix MediaWiki-Docker/Extension/CirrusSearch
 ResolvedzeljkofilipinT306178 `npm run selenium` in CirrusSearch fails with `unrecognized capability: chromeOptions`
 ResolvedzeljkofilipinT306179 `npm run @selenium-test` in CirrusSearch fails with `element not interactable`
 OpenNoneT306249 `Search with accent yields result page with accent` Selenium test fails
 ResolvedOsamaahmed17T294645 Fix MediaWiki-Docker/Extension/ElectronPdfService
 OpenNoneT294646 Fix MediaWiki-Docker/Extension/GrowthExperiments
 ResolvedOsamaahmed17T294647 Fix MediaWiki-Docker/Extension/TemplateWizard
 OpenNoneT313791 WikibaseLexeme NewLexemeAlpha:Page Selenium tests fail when targeting MediaWiki-Docker
 ResolvedReedyT329526 Update documentation to use maintenance/run.php
 OpenNoneT330093 Fix MediaWiki-Docker/Extension/ProofreadPage
 OpenNoneT330094 Fix MediaWiki-Docker/Extension/VisualEditor
 OpenNoneT330283 Fix MediaWiki-Docker/Extension/Wikistories
 OpenNoneT373671 Run Selenium tests targeting Cli
 OpenNoneT373672 Run Selenium tests targeting MediaWiki-Vagrant
 OpenNoneT373675 Run Selenium tests targeting Quibble
 OpenNoneT373677 Run Selenium tests targeting mediawiki-quickstart
 OpenNoneT373678 Run Selenium tests targeting docker-dev
 OpenNoneT373680 Run Selenium tests targeting Beta cluster
 OpenNoneT373681 Run Selenium tests targeting Patch demo
 In ProgresszeljkofilipinT280331 Switch to spec reporter
 OpenLens0021T373857 CI broken for FacetedCategory
 OpenLens0021T373863 CI broken for Sanctions
 OpenNoneT373512 `tests/selenium/docs/Stack/webdriverio.js` does not run in CI
 OpenNoneT356875 Run a linter in CI to check if all Selenium tests have correct async/await
 OpenNoneT352510 Send Selenium tests status to Prometheus
 OpenNoneT373612 WebdriverIO v8 blog post
 OpenNoneT325740 Replace Node.js Assert library with WebdriverIO Expect library
 ResolvedNik.xyz.inT331484 Change `assert` to `expect` in WikiLambda browser tests
 InvalidzeljkofilipinT258562 Use engines and engine-strict in package.json
 In ProgresszeljkofilipinT373684 Add "engines" to package.json
 ResolvedzeljkofilipinT373790 Move repositories from github to gitlab
 In ProgresszeljkofilipinT373125 Use import instead of require
 OpenNoneT329153 Remove chromedriver dependency
 OpenNoneT374266 Document QTE responsibility for Selenium framework
 OpenNoneT374267 Document how to debug a failed Jenkins job
ResolvedzeljkofilipinT256626 Refactor WebdriverIO tests from sync to async mode
 ResolvedzeljkofilipinT292853 Run Selenium tests targeting MediaWiki Core in MediaWiki-Docker
 ResolvedOllie.Shotton_WMDET343886 Refactor generic Wikibase repo WebdriverIO tests from sync to async mode

Event Timeline

Ifrahkhanyaree_WMDE created this task.Aug 9 2023, 1:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2023, 1:09 PM
Ollie.Shotton_WMDE mentioned this in T293080: Refactor Wikibase WebdriverIO tests from sync to async mode.Aug 9 2023, 2:29 PM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)Aug 10 2023, 10:14 AM
Ifrahkhanyaree_WMDE set the point value for this task to 5.
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.
Michael subscribed.Aug 15 2023, 8:40 AM
Jakob_WMDE moved this task from Ready for planning to Sprint 1 on the Wikibase Product Platform Team WPP board.Aug 15 2023, 1:59 PM
Jakob_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 1); removed Wikibase Product Platform Team WPP.
gerritbot added a comment.Aug 15 2023, 2:00 PM

Change 949051 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Start wdio sync to async migration

https://gerrit.wikimedia.org/r/949051

gerritbot added a project: Patch-For-Review.Aug 15 2023, 2:00 PM
Jakob_WMDE updated the task description. (Show Details)Aug 15 2023, 2:03 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 1) board.Aug 16 2023, 7:59 AM
Jakob_WMDE updated the task description. (Show Details)Aug 16 2023, 8:31 AM
Jakob_WMDE subscribed.
gerritbot added a comment.Aug 16 2023, 12:27 PM

Change 949508 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Migrate item.js browser test from sync to async

https://gerrit.wikimedia.org/r/949508

Jakob_WMDE updated the task description. (Show Details)Aug 16 2023, 1:34 PM
gerritbot added a comment.Aug 16 2023, 1:39 PM

Change 949051 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Start wdio sync to async migration

https://gerrit.wikimedia.org/r/949051

Michael mentioned this in T330391: [SW] [T-REF] [TECH] Remove Node14/16 fix from tainted references.Aug 16 2023, 1:51 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 16 2023, 2:08 PM
Ollie.Shotton_WMDE subscribed.
gerritbot added a comment.Aug 16 2023, 3:32 PM

Change 949508 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate item.js browser test from sync to async

https://gerrit.wikimedia.org/r/949508

gerritbot added a comment.Aug 16 2023, 3:40 PM

Change 949546 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] Migrate nonexisting.item.js browser test to async

https://gerrit.wikimedia.org/r/949546

Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 16 2023, 4:24 PM
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Aug 17 2023, 8:12 AM
Muhammad_Yasser_Jazirahly_WMDE subscribed.
gerritbot added a comment.Aug 17 2023, 10:05 AM

Change 949546 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate nonexisting.item.js browser test to async

https://gerrit.wikimedia.org/r/949546

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2023, 10:10 AM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 17 2023, 10:15 AM
gerritbot added a comment.Aug 17 2023, 12:35 PM

Change 949970 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] Migrate item.js browser test from sync to async

https://gerrit.wikimedia.org/r/949970

gerritbot added a project: Patch-For-Review.Aug 17 2023, 12:35 PM
gerritbot added a comment.Aug 17 2023, 1:51 PM

Change 949976 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] Migrate tainted-ref.js browser test from sync to async

https://gerrit.wikimedia.org/r/949976

Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Aug 17 2023, 2:30 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 17 2023, 4:29 PM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 1) board.
zeljkofilipin added a project: User-zeljkofilipin.Aug 18 2023, 11:47 AM
zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.
zeljkofilipin subscribed.
gerritbot added a comment.Aug 18 2023, 1:58 PM

Change 949976 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate tainted-ref.js browser test from sync to async

https://gerrit.wikimedia.org/r/949976

Jakob_WMDE updated the task description. (Show Details)Aug 18 2023, 2:54 PM
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Aug 21 2023, 8:58 AM
gerritbot added a comment.Aug 21 2023, 9:07 AM

Change 949970 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate readmode.references.js browser test from sync to async

https://gerrit.wikimedia.org/r/949970

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 9:10 AM
gerritbot added a comment.Aug 21 2023, 9:43 AM

Change 951062 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Use `expect` instead of `assert` for browser tests

https://gerrit.wikimedia.org/r/951062

gerritbot added a project: Patch-For-Review.Aug 21 2023, 9:43 AM
gerritbot added a comment.Aug 21 2023, 12:54 PM

Change 951062 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use `expect` instead of `assert` for browser tests

https://gerrit.wikimedia.org/r/951062

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 1:10 PM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 2 ); removed Wikibase Product Platform Team WPP (Sprint 1).Aug 22 2023, 9:12 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 2 ) board.
gerritbot added a comment.Aug 23 2023, 10:04 AM

Change 951892 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] Improve browser tests after async migration

https://gerrit.wikimedia.org/r/951892

gerritbot added a project: Patch-For-Review.Aug 23 2023, 10:04 AM
gerritbot added a comment.Aug 23 2023, 1:49 PM

Change 951932 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Use newly released wdio-wikibase v6

https://gerrit.wikimedia.org/r/951932

gerritbot added a comment.Aug 23 2023, 2:36 PM

Change 951932 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use newly released wdio-wikibase v6

https://gerrit.wikimedia.org/r/951932

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 23 2023, 2:52 PM
gerritbot added a comment.Aug 23 2023, 3:08 PM

Change 951892 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Improve browser tests after async migration

https://gerrit.wikimedia.org/r/951892

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 3:31 PM
Ollie.Shotton_WMDE closed this task as Resolved.Aug 23 2023, 3:58 PM
Ollie.Shotton_WMDE claimed this task.

Marking task resolved. All related commits are merged and a new version of the wdio-wikibase package published to npm.

zeljkofilipin mentioned this in T300811: Refactor Wdio-Wikibase WebdriverIO tests from sync to async mode.Aug 23 2023, 4:43 PM
zeljkofilipin added a parent task: T256626: Refactor WebdriverIO tests from sync to async mode.
zeljkofilipin mentioned this in T256626: Refactor WebdriverIO tests from sync to async mode.
Ollie.Shotton_WMDE added a parent task: T293080: Refactor Wikibase WebdriverIO tests from sync to async mode.Aug 23 2023, 5:05 PM
gerritbot added a comment.Aug 25 2023, 10:24 PM

Change 952440 had a related patch set uploaded (by Paladox; author: Jakob):

[mediawiki/extensions/Wikibase@REL1_40] Start wdio sync to async migration

https://gerrit.wikimedia.org/r/952440

gerritbot added a project: Patch-For-Review.Aug 25 2023, 10:24 PM
gerritbot added a comment.Aug 26 2023, 12:10 PM

Change 952522 had a related patch set uploaded (by Paladox; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@REL1_40] Migrate nonexisting.item.js browser test to async

https://gerrit.wikimedia.org/r/952522

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 6:10 PM
gerritbot added a comment.Oct 15 2023, 7:42 PM

Change 952522 abandoned by Paladox:

[mediawiki/extensions/Wikibase@REL1_40] Migrate nonexisting.item.js browser test to async

Reason:

https://gerrit.wikimedia.org/r/952522

gerritbot added a comment.Oct 15 2023, 7:45 PM

Change 952440 abandoned by Paladox:

[mediawiki/extensions/Wikibase@REL1_40] Start wdio sync to async migration

Reason:

https://gerrit.wikimedia.org/r/952440

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2023, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits