The -12px right margin on .minerva-user-navigation renders beyond the page area, triggering horizontal scroll:
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T343908 |
| 2 | ✅ | T343908#9081336 |
| 3 | ✅ | T343908#9085304 |
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T335440 [EPIC] Web team support for IP masking | |||
| Resolved | ovasileva | T319260 IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex) | |||
| Resolved | Jdlrobson | T342907 Mobile Echo code scattered between Minerva, Echo and MobileFrontend extensions | |||
| Resolved | Jdlrobson | T343908 Page scrolls horizontally when AMC is enabled |
Event Timeline
Comment Actions
Regression appears to be from here: https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/943647/21/resources/skins.minerva.base.styles/userMenu.less where the negative margin moved from a child selector to the parent.
Comment Actions
This has a knock-on effect on position:sticky content, like the new topic button in DiscussionTools, which is now too low:
Comment Actions
Change 947420 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Any header overflow should be hidden
Comment Actions
Change 947420 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Any header overflow should be hidden
Comment Actions
Status:❌ Fail
Environment: Beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device: via Developer Tools
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Bear
❌ AC1: T343908- Horizontal scroll beyond the page area at random times when moving left/right. Though horizontal scrolling was on my mouse side scroller, not touch so not sure how you want to proceed with that.
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
❌ AC2: T343908#9081336- Add Topic not centered
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Bear
Comment Actions
Change 947444 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/MinervaNeue@master] Fix header overflow style causing header buttons from being cut off
Comment Actions
The first thing to consider when adding overflow:hidden is if the elements has any popups attached that break the bounding box. In this case the user menu popup will get completely truncated.
Comment Actions
Change 947455 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/skins/MinervaNeue@master] Revert "Any header overflow should be hidden"
Comment Actions
Change 947455 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revert "Any header overflow should be hidden"
Comment Actions
Change 947444 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix header overflow style causing header buttons from being cut off
Comment Actions
Status:✅ PASS
Environment: Beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device: via Developer Tools
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Bear
✅ AC1: T343908- Horizontal scroll beyond the page area at random times when moving left/right. Though horizontal scrolling was on my mouse side scroller, not touch so not sure how you want to proceed with that.
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Bear
✅ AC2: T343908#9081336- Add Topic not centered
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
✅AC3: Fix header overflow style causing header buttons from being cut off
| Advance Mode: On | Advance Mode: Off |
Possible Issue @Jdlrobson : When logged in, "Discussion" appears. Would you want it to be horizontally centered too?
