Page MenuHomePhabricator
Create Task
Maniphest T344312

Use InsertQueryBuilder in CheckUser
Closed, ResolvedPublic
Actions

Description

The InsertQueryBuilder added in d95a6b3167d23e68cf004516e3a8a2234a8bad6a allows inserting using a builder interface. This is easier to read than the current IDatabase::insert method used in CheckUser. Ideally, CheckUser code should use the new InsertQueryBuilder to insert to the database.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use InsertQueryBuilder in CheckUser instead of IDatabase::insertmediawiki/extensions/CheckUsermaster+89 -40
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Aug 16 2023, 6:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2023, 6:57 AM
Dreamy_Jazz updated the task description. (Show Details)Aug 16 2023, 6:58 AM
gerritbot added a comment.Aug 16 2023, 7:24 AM

Change 949482 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use InsertQueryBuilder in CheckUser instead of IDatabase::insert

https://gerrit.wikimedia.org/r/949482

gerritbot added a project: Patch-For-Review.Aug 16 2023, 7:24 AM
Dreamy_Jazz added a parent task: T335377: Create QueryBuilders for common database queries.Aug 16 2023, 7:26 AM
Dreamy_Jazz removed a parent task: T335377: Create QueryBuilders for common database queries.
Dreamy_Jazz moved this task from Inbox to Hacking Projects on the Wikimania-Hackathon-2023 board.
gerritbot added a comment.Aug 19 2023, 3:43 AM

Change 949482 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use InsertQueryBuilder in CheckUser instead of IDatabase::insert

https://gerrit.wikimedia.org/r/949482

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2023, 4:10 AM
Dreamy_Jazz closed this task as Resolved.Aug 29 2023, 11:38 AM
Dreamy_Jazz claimed this task.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits