Page MenuHomePhabricator
Create Task
Maniphest T344403

Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'wikidatawiki'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
message
[ed07cfa5-cd66-4dbd-a1ae-0b48c1b3fbb7] /w/index.php?title=Special:Investigate/Account_information&token=yyy   Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'wikidatawiki'
trace
from /srv/mediawiki/php-1.41.0-wmf.22/includes/dao/WikiAwareEntityTrait.php(59)
#0 /srv/mediawiki/php-1.41.0-wmf.22/includes/user/UserGroupManager.php(718): MediaWiki\User\UserIdentityValue->assertWiki(boolean)
#1 /srv/mediawiki/php-1.41.0-wmf.22/includes/user/UserGroupManager.php(703): MediaWiki\User\UserGroupManager->getUserGroupMemberships(MediaWiki\User\UserIdentityValue, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.22/extensions/CheckUser/src/Investigate/Services/PreliminaryCheckService.php(179): MediaWiki\User\UserGroupManager->getUserGroups(MediaWiki\User\UserIdentityValue)
#3 /srv/mediawiki/php-1.41.0-wmf.22/extensions/CheckUser/src/Investigate/Services/PreliminaryCheckService.php(133): MediaWiki\CheckUser\Investigate\Services\PreliminaryCheckService->getAdditionalLocalData(stdClass, string)
#4 /srv/mediawiki/php-1.41.0-wmf.22/extensions/CheckUser/src/Investigate/Pagers/PreliminaryCheckPager.php(258): MediaWiki\CheckUser\Investigate\Services\PreliminaryCheckService->preprocessResults(Wikimedia\Rdbms\MysqliResultWrapper)
#5 /srv/mediawiki/php-1.41.0-wmf.22/includes/pager/IndexPager.php(291): MediaWiki\CheckUser\Investigate\Pagers\PreliminaryCheckPager->preprocessResults(Wikimedia\Rdbms\MysqliResultWrapper)
#6 /srv/mediawiki/php-1.41.0-wmf.22/includes/pager/IndexPager.php(733): IndexPager->doQuery()
#7 /srv/mediawiki/php-1.41.0-wmf.22/extensions/CheckUser/src/Investigate/SpecialInvestigate.php(342): IndexPager->getNumRows()
#8 /srv/mediawiki/php-1.41.0-wmf.22/extensions/CheckUser/src/Investigate/SpecialInvestigate.php(205): MediaWiki\CheckUser\Investigate\SpecialInvestigate->addTabContent(string)
#9 /srv/mediawiki/php-1.41.0-wmf.22/includes/specialpage/SpecialPage.php(701): MediaWiki\CheckUser\Investigate\SpecialInvestigate->execute(string)
#10 /srv/mediawiki/php-1.41.0-wmf.22/includes/specialpage/SpecialPageFactory.php(1565): SpecialPage->run(string)
#11 /srv/mediawiki/php-1.41.0-wmf.22/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#12 /srv/mediawiki/php-1.41.0-wmf.22/includes/MediaWiki.php(942): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.41.0-wmf.22/includes/MediaWiki.php(591): MediaWiki->main()
#14 /srv/mediawiki/php-1.41.0-wmf.22/index.php(50): MediaWiki->run()
#15 /srv/mediawiki/php-1.41.0-wmf.22/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Impact
Notes

Details

MediaWiki Version
1.41.0-wmf.22
Request URL
/w/index.php?title=Special:Investigate/Account_information&token=yyy
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use UserIdentity::LOCAL in PreliminaryCheckService when appropriatemediawiki/extensions/CheckUserwmf/1.41.0-wmf.22+7 -3
Use UserIdentity::LOCAL in PreliminaryCheckService when appropriatemediawiki/extensions/CheckUserwmf/1.41.0-wmf.20+7 -3
Use UserIdentity::LOCAL in PreliminaryCheckService when appropriatemediawiki/extensions/CheckUsermaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Aug 17 2023, 4:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2023, 4:38 AM
Dreamy_Jazz set Release Version to 1.41.0-wmf.22.Aug 17 2023, 4:39 AM
Dreamy_Jazz added a comment.Aug 17 2023, 4:45 AM

Re-producable on enwiki. Seems to be a reincarnation of T342655.

Dreamy_Jazz triaged this task as High priority.Aug 17 2023, 4:46 AM

This isn't a train blocker, as I can re-produce it on a group2 wiki but otherwise breaks Special:Investigate.

Dreamy_Jazz edited projects, added Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment-Team.Aug 17 2023, 4:49 AM

This is the second time this has broken in a few weeks. Ideally some tests should be written.

Dreamy_Jazz added a comment.Aug 17 2023, 5:41 AM

Caused by WikiAwareEntity::LOCAL not being the same as the DB name of the local wiki. Will make a patch.

Dreamy_Jazz added a comment.Aug 17 2023, 5:57 AM

The tests do not catch this as they mock the UserGroupManager service. This means the parameters provided to getUserGroups are never validated to provide the expected groups without exception. To avoid re-writing the tests in a patch that would be backported, I will leave the tests as they are.

gerritbot added a comment.Aug 17 2023, 6:06 AM

Change 949622 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949622

gerritbot added a project: Patch-For-Review.Aug 17 2023, 6:06 AM
gerritbot added a comment.Aug 17 2023, 6:12 AM

Change 949573 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.22] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949573

gerritbot added a comment.Aug 17 2023, 6:13 AM

Change 949574 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.20] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949574

gerritbot added a comment.Aug 17 2023, 7:26 AM

Change 949622 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949622

gerritbot added a comment.Aug 17 2023, 7:31 AM

Change 949574 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.20] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949574

gerritbot added a comment.Aug 17 2023, 7:32 AM

Change 949573 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.41.0-wmf.22] Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate

https://gerrit.wikimedia.org/r/949573

Stashbot added a comment.Aug 17 2023, 7:33 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T07:33:00Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:949573|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]], [[gerrit:949574|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]]

Stashbot added a comment.Aug 17 2023, 7:34 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T07:34:43Z] <taavi@deploy1002> dreamyjazz and taavi: Backport for [[gerrit:949573|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]], [[gerrit:949574|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible vi

Dreamy_Jazz closed this task as Resolved.Aug 17 2023, 7:38 AM
Dreamy_Jazz claimed this task.
Dreamy_Jazz edited projects, added Anti-Harassment-Team; removed Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).

Fixed on production via a backport.

Stashbot added a comment.Aug 17 2023, 7:44 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T07:44:26Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:949573|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]], [[gerrit:949574|Use UserIdentity::LOCAL in PreliminaryCheckService when appropriate (T344403)]] (duration: 11m 25s)

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2023, 8:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 7:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits