Maniphest T344416

Wikibase secondary CI fails on ItemHandlerTest with `NoSuchServiceException: No such service: WikibaseClient.SiteGroup`
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Michael
	Aug 17 2023, 9:56 AM

Tags

Referenced Files

None

Subscribers

Description

First failing job: https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/5778927629/job/15660659892
Seemingly caused by: Avoid DB access in non-Database tests (Icb3b3ad7)

That change was merged 10 days ago. We didn't notice it until now because email sending was also broken, separately. That is tracked in T344415.

Details

	Subject	Repo	Branch	Lines +/-
	tests: don't set client service if client is not enabled	mediawiki/extensions/Wikibase	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T344415: Wikibase secondary CI email sending is broken
Mentioned Here: T344415: Wikibase secondary CI email sending is broken

Event Timeline

Michael created this task.Aug 17 2023, 9:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2023, 9:56 AM

Michael claimed this task.Aug 17 2023, 10:07 AM

Michael mentioned this in T344415: Wikibase secondary CI email sending is broken.

Michael added a project: Wikidata Dev Team (Sprint-∞).

Restricted Application added a project: User-Michael. · View Herald TranscriptAug 17 2023, 10:08 AM

Michael moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.Aug 17 2023, 10:10 AM

Change 949958 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] tests: don't set client service if client is not enabled

https://gerrit.wikimedia.org/r/949958

gerritbot added a project: Patch-For-Review.Aug 17 2023, 11:46 AM

Change 949958 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: don't set client service if client is not enabled

https://gerrit.wikimedia.org/r/949958

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2023, 5:30 PM

Secondary CI is green again.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 8:02 PM

I think there is nothing that needs doing here anymore.