Page MenuHomePhabricator
Create Task
Maniphest T344455

Delete Z110 and Z210
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
You cannot save the edit because type for input and output for the function are required in the English section (that has not been changed).

What should have happened instead?:
The edit should be saved

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (958de5c)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ameisenigel created this task.Aug 17 2023, 6:58 PM
Jdforrester-WMF triaged this task as Low priority.Sep 14 2023, 5:21 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

Oops, clean-up needed!

DVrandecic renamed this task from Not possible to add a label in another language to Z110 to Delete Z110 and Z210.EditedSep 20 2023, 11:14 PM
DVrandecic subscribed.

The original task was about "It is not possible to add labels to Z110".

This is correct, but the actual solution to this is that Z110 and Z210 should be deleted. Z10 was removed as a type, and therefore Z110 - which is the validator for Z10 - and Z210 - which is the builtin for Z110 - are not needed anymore as well.

The deletion should happen on wikifunctions.org itself as well as in function-schemata.

Quiddity subscribed.Sep 22 2023, 11:14 PM

Do we also need to update the entry for Z10 within https://www.wikifunctions.org/wiki/Wikifunctions:Reserved_ZIDs to specify it has been [removed? deleted?] ? Or will it return in the future?

CodeReviewBot added a project: Patch-For-Review.Sep 25 2023, 5:21 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/38

definitions: Drop Z110 and Z210, no longer needed

CodeReviewBot added a comment.Sep 27 2023, 12:55 AM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/38

definitions: Drop Z110 and Z210, no longer needed

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2023, 1:10 AM
Jdforrester-WMF claimed this task.Sep 27 2023, 1:41 PM
Jdforrester-WMF moved this task from Backlog to Verify in production on the Abstract Wikipedia team board.

I've manually deleted the pages from production and Beta Cluster, and they're now no longer defined (except for pull-through trivial patches). Let's call this Done.

Jdforrester-WMF added a comment.Sep 27 2023, 1:42 PM
In T344455#9192740, @Quiddity wrote:

Do we also need to update the entry for Z10 within https://www.wikifunctions.org/wiki/Wikifunctions:Reserved_ZIDs to specify it has been [removed? deleted?] ? Or will it return in the future?

My understanding is that it will (probably) return in the future, but we're not doing any work on it soon.

Etonkovidova closed this task as Resolved.Sep 27 2023, 8:36 PM
gerritbot added a comment.Sep 28 2023, 4:26 PM

Change 961848 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (958de5c)

https://gerrit.wikimedia.org/r/961848

gerritbot added a project: Patch-For-Review.Sep 28 2023, 4:26 PM
CodeReviewBot added a comment.Sep 28 2023, 4:31 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/65

Drop references to delete Z110 and Z210

gerritbot added a comment.Sep 28 2023, 5:16 PM

Change 961848 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (958de5c)

https://gerrit.wikimedia.org/r/961848

CodeReviewBot added a comment.Sep 28 2023, 5:19 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/65

Drop references to delete Z110 and Z210

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 5:31 PM
DMartin-WMF mentioned this in rMSFE13181c9f6e6a: Update function-schemata sub-module to HEAD (958de5c).Oct 3 2025, 9:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits