Page MenuHomePhabricator

[wmf.22] mobile - New impact module info tooltips display duplicate titles
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • As a user with no edits, go to Special:Homepage and click on the Impact module
  • On the New Impact module overlay click the info buttons:
Screen Shot 2023-08-18 at 9.57.35 AM.png (1×898 px, 200 KB)
Screen Shot 2023-08-18 at 9.57.26 AM.png (1×866 px, 108 KB)
  • the title is repeated (checked on testwiki, ptwiki, and cswiki)
  • on cswiki, the issue causes some wrapping problem in that additional title on mobile with screen width 360-412:

Screen Shot 2023-08-18 at 10.01.10 AM.png (1×756 px, 229 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 950171 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] NoEditsDisplay: Do not duplicate title

https://gerrit.wikimedia.org/r/950171

Thanks for noticing this! It seems to be a Regression from T340199 -- uploaded a fix.

There's apparently still a minor formatting issue (the title seems to be fairly close to the popover edge):

image.png (1×1 px, 191 KB)

For comparsion, see the other popover, which title seems to be more far from the edge:

image.png (1×1 px, 142 KB)

Or maybe it behave that way before? @Sgs, can you have a look at this please?

Thanks for noticing this! It seems to be a Regression from T340199 -- uploaded a fix.

There's apparently still a minor formatting issue (the title seems to be fairly close to the popover edge):

image.png (1×1 px, 191 KB)

For comparsion, see the other popover, which title seems to be more far from the edge:

image.png (1×1 px, 142 KB)

Or maybe it behave that way before? @Sgs, can you have a look at this please?

Thanks for the quick reaction, I'll push a patchset on top of yours to fix the multi-line header issue. I'm not 100% sure if the regression is from T340199 or T339106. Seems trivial enough to fix all together.

Change 950171 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NoEditsDisplay: Do not duplicate title

https://gerrit.wikimedia.org/r/950171

Thanks for the help with the other issue @Sgs! Moving to QA now.