Page MenuHomePhabricator

Android app menu icons are SUPER HUGE on mdpi devices (G1, Kindle Fire)
Closed, ResolvedPublic

Description

Screenshot in Android emulator, 2.3 at mdpi

The android menu plugin is doing some fairly broken things with icon sizing; the current icons display at about the right size only on hdpi (240dpi / 1.5x multiplier) devices. On mdpi (160dpi / 1.0 multiplier) such as an emulator configuration like the classic G1 or the new Amazon Kindle Fire tablet, they're REALLY HUGE and actually block out the text entirely.

Setting as a blocker on the 1.0 release tracking bug 31447.


Version: 1.0.0 (Android)
Severity: normal

Attached:

Details

Reference
bz32449

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 12:07 AM
bzimport set Reference to bz32449.
bzimport added a subscriber: Unknown Object (MLST).
brion created this task.Nov 16 2011, 9:30 PM
brion added a comment.Nov 16 2011, 9:32 PM

Created attachment 9478
Screenshot on Kindle Fire

An Android 2.3-based tablet without proprietary Google APIs (running with the provisional fix from bug 32445). Shows the same icon sizing error as regular phone emu also at mdpi.

Attached:

This question on stack overflow is relevant:

http://stackoverflow.com/questions/7361976/how-to-create-a-drawable-from-a-stream-without-resizing-it

hacking in the suggested fix there into AppMenu's getIcon() ends up with the icons always being drawn at native device resolution, which is what we'd want when loading icons sized for each resolution:

https://github.com/brion/Wikipedia/tree/icon-fixed-size

Alternatively, it could be switched from loading icons out of the Android resources and we can just let the native system take over (resolving from the right subdirs, properly scaling the default size if no native one available). If these icons are meant to be Android-specific then that's probably the nicest thing to do.

brion added a comment.Nov 21 2011, 3:42 AM

Ok I've got a combination of the various bits together with quickly bulk-resized images as pull req: https://github.com/nitobi/Wikipedia/pull/59