Page MenuHomePhabricator
Create Task
Maniphest T344568

PHP deprecations: json_decode() / explode(): Passing null to parameter $string is deprecated
Closed, ResolvedPublic
Actions

Description

Never reported a bug before so I have no idea if this is the correct way, but I'm giving it a try.

When using Torblock on MediaWiki 1.40.0 I get these error messages on the edit page:

Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in /usr/local/var/www/includes/json/FormatJson.php on line 147

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /usr/local/var/www/extensions/TorBlock/includes/TorExitNodes.php on line 144

It also seems to interfere with CharInser on the edit page.

MediaWiki 1.40.0
PHP 8.2.7 (apache2handler)
ICU 73.2
MySQL 8.0.33
Lua 5.1.5
Pygments 2.11.2

CharInsert (cea41d5) 27 juli 2023 kl. 07.45
TorBlock 1.1.0 (fb03d2c) 27 juli 2023 kl. 07.50

MediaWiki is on my personal Mac for now since I want it to work before I start renting a web server. MacOS Monterey 12.6.6, 3,2 GHz Quad-Core i5, 24 GB RAM.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
TorExitNodes: Add some error handling for HTTP GET requests returning nullReedymediawiki/extensions/TorBlockREL1_39+12 -0
TorExitNodes: Add some error handling for HTTP GET requests returning nullReedymediawiki/extensions/TorBlockREL1_40+12 -0
TorExitNodes: Add some error handling for HTTP GET requests returning nullReedymediawiki/extensions/TorBlockmaster+12 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Machatjkala created this task.Aug 20 2023, 9:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2023, 9:55 AM
Aklapper added a project: PHP 8.1 support.Aug 20 2023, 2:51 PM

Hi @Machatjkala, thanks for taking the time to report this and welcome to Wikimedia Phabricator! For future reference, please use the bug report form (linked from the top of the task creation page) to create a bug report, and fill in the sections in the template. Thanks.

Aklapper renamed this task from Tor block with mediawiki 1.40.0 to PHP deprecations: json_decode() / explode(): Passing null to parameter $string is deprecated.Aug 20 2023, 2:52 PM
Izno added a parent task: T289926: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning).Aug 20 2023, 6:36 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Aug 26 2023, 6:12 PM
Reedy added a project: MW-1.40-release.
gerritbot added a comment.Aug 26 2023, 6:16 PM

Change 952536 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TorBlock@master] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/952536

gerritbot added a project: Patch-For-Review.Aug 26 2023, 6:16 PM
Reedy subscribed.Aug 26 2023, 6:17 PM

Does it always happen? Or only intermittantly?

The obvious answer would look to be that your machine is unable to make requests to a couple of different Tor related urls...

Patch adds some logging (and very basic handling) of these cases...

Reedy added a comment.Aug 26 2023, 6:19 PM

You can get some more info by setting a 'http' log for https://www.mediawiki.org/wiki/Manual:$wgDebugLogGroups too

Reedy moved this task from Blocker to Not a blocker on the MW-1.40-release board.Aug 26 2023, 6:33 PM
Machatjkala added a comment.Aug 28 2023, 4:12 PM
In T344568#9121660, @Reedy wrote:

Does it always happen? Or only intermittantly?

The obvious answer would look to be that your machine is unable to make requests to a couple of different Tor related urls...

Patch adds some logging (and very basic handling) of these cases...

Always on edit pages. Haven't seen it anywhere else.

gerritbot added a comment.Aug 29 2023, 5:25 PM

Change 952536 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@master] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/952536

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2023, 5:31 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 5:01 AM
gerritbot added a comment.Sep 20 2023, 5:03 PM

Change 959290 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TorBlock@REL1_40] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/959290

gerritbot added a project: Patch-For-Review.Sep 20 2023, 5:03 PM

Change 959291 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TorBlock@REL1_39] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/959291

gerritbot added a comment.Sep 20 2023, 5:09 PM

Change 959290 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@REL1_40] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/959290

gerritbot added a comment.Sep 20 2023, 5:23 PM

Change 959291 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@REL1_39] TorExitNodes: Add some error handling for HTTP GET requests returning null

https://gerrit.wikimedia.org/r/959291

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 5:31 PM
Reedy closed this task as Resolved.Oct 7 2023, 6:31 PM
Reedy claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits