$this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning()
Closed, InvalidPublicBUG REPORT
Actions

Assigned To

None

Authored By

	alex-mashin
	Aug 21 2023, 6:10 AM

Description

To reproduce, using release 1.35, create a form with an uploadable field, and upload a file with it, specifying a license.

Then an error Using $this in static context will appear.

It affects, at least, lines 483, 485, 491, 493 of PFUploadWindow::getInitialPageText(). Perhaps, this method should not be static.

UPD: also affected: PFUploadWindow::getExistsWarning(), lines 637, 640, 642, 646, 652, 668.

Event Timeline

alex-mashin created this task.Aug 21 2023, 6:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2023, 6:10 AM

alex-mashin updated the task description. (Show Details)Aug 21 2023, 6:18 AM

alex-mashin renamed this task from $this in static method PFUploadWindow::getInitialPageText() to $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning().Aug 21 2023, 8:25 AM

It sounds like you are using the REL1_35 branch of Page Forms. You should switch to the most recent version of Page Forms, which thankfully still supports MW 1.35 - I think this particular bug, or set of bugs, was fixed a long time ago.

In T344578#9106334, @Yaron_Koren wrote:

It sounds like you are using the REL1_35 branch of Page Forms. You should switch to the most recent version of Page Forms, which thankfully still supports MW 1.35 - I think this particular bug, or set of bugs, was fixed a long time ago.

Thank you, switching to master helped.

alex-mashin closed this task as Invalid.Aug 21 2023, 2:53 PM

$this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning()Closed, InvalidPublicBUG REPORTActions

Description

Event Timeline

$this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning()
Closed, InvalidPublicBUG REPORT
Actions