Page MenuHomePhabricator

Update requireLogin() for temp users on CentralAuth extension
Closed, ResolvedPublic

Description

In T344276, we want to make sure the SpecialPage::requireLogin() function is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Should requireLogin() be available to temporary users?
If yes, no update is needed.
If not, requireNamedUser must return true instead.

Notes:
RequireLogin was found in the following files:
SpecialCreateLocalAccount.php
SpecialGlobalRenameRequest.php
Code Search Link

Event Timeline

For SpecialGlobalRenameRequest.php I think requireNamedUser should be used, as renaming temporary accounts is something that is disabled in T326926: Prepare Renameuser extension for IP Masking.

Change 989450 had a related patch set uploaded (by ArielGlenn; author: ArielGlenn):

[mediawiki/extensions/CentralAuth@master] Disallow temp users from requesting global renames

https://gerrit.wikimedia.org/r/989450

Change 989453 had a related patch set uploaded (by ArielGlenn; author: ArielGlenn):

[mediawiki/extensions/CentralAuth@master] Disallow temp users from manually creating local accounts for global users

https://gerrit.wikimedia.org/r/989453

Change 989450 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Disallow temp users from requesting global renames

https://gerrit.wikimedia.org/r/989450

Change 989453 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Disallow temp users from manually creating local accounts for global users

https://gerrit.wikimedia.org/r/989453

Change 990698 had a related patch set uploaded (by ArielGlenn; author: ArielGlenn):

[mediawiki/extensions/CentralAuth@master] Don't allow temp users to do global renames via the special page

https://gerrit.wikimedia.org/r/990698

Change 990698 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Don't allow temp usernames to be used in global renames via the special page

https://gerrit.wikimedia.org/r/990698

Tgr assigned this task to ArielGlenn.