Page MenuHomePhabricator

Update requireLogin() for temp users on Newsletter extension
Closed, DeclinedPublic

Description

In T344276, we want to make sure the SpecialPage::requireLogin() function is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Should requireLogin() be available to temporary users?
If yes, no update is needed.
If not, requireNamedUser must return true instead.

Notes:
RequireLogin was found in the following files:
includes/Specials/SpecialNewsletter.php
includes/Specials/SpecialNewsletterCreate.php
Code Search Link

Event Timeline

I see no specific reason why temporary users shouldn't be allowed to create Newsletters, if the wiki config gives them the newsletter-create right. Likewise per T330509: [IP Masking] Make Echo Notifications available to temporary users temp users can receive notifications, so they should be allowed to subscribe as well. Proposing to close without action.

I see no specific reason why temporary users shouldn't be allowed to create Newsletters, if the wiki config gives them the newsletter-create right. Likewise per T330509: [IP Masking] Make Echo Notifications available to temporary users temp users can receive notifications, so they should be allowed to subscribe as well. Proposing to close without action.

Thanks for this.
Closing without action then.

JJMC89 changed the task status from Resolved to Declined.Aug 23 2023, 2:10 PM