Page MenuHomePhabricator

Update requireLogin() for temp users on Wikistories extension
Closed, ResolvedPublic

Description

In T344276, we want to make sure the SpecialPage::requireLogin() function is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Should requireLogin() be available to temporary users?
If yes, no update is needed.
If not, requireNamedUser must return true instead.

Notes:
RequireLogin was found in the following files:
includes/SpecialStoryBuilder.php
Code Search Link

Event Timeline

Amdrel changed the task status from Open to In Progress.Sep 24 2024, 6:54 PM
Amdrel claimed this task.

Change #1075319 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/Wikistories@master] Add 'requireNamedUser' check to Special:StoryBuilder

https://gerrit.wikimedia.org/r/1075319

Change #1075319 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Add 'requireNamedUser' check to Special:StoryBuilder

https://gerrit.wikimedia.org/r/1075319

Djackson-ctr subscribed.

QA has been completed, and the new code change(s) are functioning as expected (when temporary account users try to access Special:StoryBuilder, the user will be redirected to the Special:UserLogin page).

image.png (1,835×463 px, 72 KB)