Page MenuHomePhabricator

Migrate Mathoid to GitLab
Closed, ResolvedPublic

Description

Repo:

Blockers:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I see that there is already some outdated fork on gitlab https://gitlab.wikimedia.org/repos/releng/mathoid/. I think it would be great if we can use the latest version for migration (Change-Id: I9d403e442f1fbcfe4c3da1d90fce43ecf152889e)

@thcipriani, maybe we can postpone this until extension-Math and extension-MathSearch are also moved to GitLab. At least it would be more convenient to configure the permissions all in one place (currently https://gerrit.wikimedia.org/r/admin/groups/uuid-1af31a28bf4fe34292f8ac9d9bdae6f78c7a18fd (group name math)).

@thcipriani, maybe we can postpone this until extension-Math and extension-MathSearch are also moved to GitLab. At least it would be more convenient to configure the permissions all in one place (currently https://gerrit.wikimedia.org/r/admin/groups/uuid-1af31a28bf4fe34292f8ac9d9bdae6f78c7a18fd (group name math)).

No, we want to move all services right now, not wait months for the plan for MW migration to be ready. The ACL for the production services and the production extensions won't necessarily be the same, but that's a different consideration.

@Jdforrester-WMF, I still don't understand how this will work. It is unclear to me if the deployment process will be the same?

The docu says

✅ Continuously publish image artifacts to our production Docker registry

which means that new mathoid images could be build in theory. However, I wonder what would replace the change to the deployment charts such as https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/919375?

@Jdforrester-WMF, I still don't understand how this will work. It is unclear to me if the deployment process will be the same?

Yes. You'll still need to deploy manually to production from a merged commit to deployment-charts. These will no longer be created automatically, but the hard work of deploying remains the same.

The docu says

✅ Continuously publish image artifacts to our production Docker registry

which means that new mathoid images could be build in theory. However, I wonder what would replace the change to the deployment charts such as https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/919375?

That's about what images exist, which is already true. (The name of the image will change and that'll be the first thing to change in the deployment-charts repo.)

@Jdforrester-WMF, I still don't understand how this will work. It is unclear to me if the deployment process will be the same?

These will no longer be created automatically,

We will (hopefully soon) build something to support this in GitLab.

Thank you for the details. I have no objections. The automated creation of deployment patches was more confusing than helpful in the past, because most of them were never merged and it requires special permissions to abandon them.

However, I think if https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/919375 can be merged before this would be great.

OK, this is ready to do, but I don't have the rights to import into mediawiki/services for some reason. @thcipriani, do you want to do so?

@Jdforrester-WMF I bumped your role to Owner in the repos/mediawiki tree. Lemme know if that gets you moving.

@Jdforrester-WMF I bumped your role to Owner in the repos/mediawiki tree. Lemme know if that gets you moving.

That worked, thank you!

@Physikerwelt, you'll want to change your local git clone to GitLab via git remote set-url origin git@gitlab.wikimedia.org:repos/mediawiki/services/mathoid and note that the primary branch is now main, and you'll want to delete your .git/hooks/pre-commit file. To create a new MR, do git push origin <branchname> and then follow the prompted Web address to create it, like GitHub.

Once we've published our first image I suppose this'll be Resolved, or do we also want to switch over the deployment-char?

physikerwelt merged https://gitlab.wikimedia.org/repos/mediawiki/services/mathoid/-/merge_requests/1

build: Install standard node 16 CI for linting/testing/publishing/coverage

Change 956492 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] [mathoid] Switch image to GitLab-published one

https://gerrit.wikimedia.org/r/956492

Change 956493 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/services/mathoid] Mark as archived, moved to GitLab

https://gerrit.wikimedia.org/r/956493

Change 956494 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Drop mathoid custom jobs, repo is now on GitLab

https://gerrit.wikimedia.org/r/956494

Change 956495 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/mathoid@master] Empty repo, point people to the new Wikimedia GitLab one

https://gerrit.wikimedia.org/r/956495

Change 956493 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/services/mathoid] Mark as archived, moved to GitLab

https://gerrit.wikimedia.org/r/956493

Mentioned in SAL (#wikimedia-releng) [2023-09-11T21:09:49Z] <James_F> Zuul: [mediawiki/services/mathoid] Mark as archived, moved to GitLab for T344747

Change 956495 merged by Jforrester:

[mediawiki/services/mathoid@master] Empty repo, point people to the new Wikimedia GitLab one

https://gerrit.wikimedia.org/r/956495

Change 956494 merged by jenkins-bot:

[integration/config@master] jjb: Drop mathoid custom jobs, repo is now on GitLab

https://gerrit.wikimedia.org/r/956494

@Jdforrester-WMF I bumped your role to Owner in the repos/mediawiki tree. Lemme know if that gets you moving.

That worked, thank you!

@Physikerwelt, you'll want to change your local git clone to GitLab via git remote set-url origin git@gitlab.wikimedia.org:repos/mediawiki/services/mathoid and note that the primary branch is now main, and you'll want to delete your .git/hooks/pre-commit file. To create a new MR, do git push origin <branchname> and then follow the prompted Web address to create it, like GitHub.

OK. Cool. Maybe for long term use https://gitlab.com/gitlab-org/cli will be convenient.

Once we've published our first image I suppose this'll be Resolved, or do we also want to switch over the deployment-char?

Why not😉

Change 956868 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Math@master] docs: Update links for Mathoid now it's moved to GitLab

https://gerrit.wikimedia.org/r/956868

Change 956868 merged by jenkins-bot:

[mediawiki/extensions/Math@master] docs: Update links for Mathoid now it's moved to GitLab

https://gerrit.wikimedia.org/r/956868

Change 956492 merged by jenkins-bot:

[operations/deployment-charts@master] [mathoid] Switch image to GitLab-published one

https://gerrit.wikimedia.org/r/956492

Jdforrester-WMF claimed this task.
Jdforrester-WMF updated the task description. (Show Details)

OK, I've deployed the change switching the source to GitLab, and all seems well. Resolving.