Page MenuHomePhabricator

Decrease CheckUserClientHintsRestApiMaxTimeLag config on production wikis
Closed, DeclinedPublic

Description

The default value of wgCheckUserClientHintsRestApiMaxTimeLag was set as 30 minutes. This was chosen with some guess-work. Now that collection is enabled on all wikis, it makes sense to attempt to experiment with reducing this to find a happy medium. This is because:

  1. Logstash already indicates experimentation with the API within 30 minutes after edits were made (T344787)
  2. 30 minutes is likely too long and in the case of shared PCs (such as a library), Client Hints data could be reasonably stored by someone else if the user was logged out to make the edit.

The reduction will be done in steps. Between each reduction, logstash will be inspected to determine whether there is an unacceptable increase in rejected requests due to the edit being made too long ago. Once a reasonable number is determined, this can be set as the default for the extension.

Planned steps:

  • Lower the limit to 5 minutes on group0 and group1 - https://gerrit.wikimedia.org/r/951833
  • Lower the limit to 5 minutes on all wikis
  • Lower the limit to 1 minute on group0 and group1
  • Lower the limit to 1 minute on all wikis
  • Lower the limit to 30 seconds on group0 and group1
  • Lower the limit to 30 seconds on all wikis

Event Timeline

Change 951833 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] clienthints: Lower API max lag time to 5 minutes on group0 and 1

https://gerrit.wikimedia.org/r/951833

Change 951833 merged by jenkins-bot:

[operations/mediawiki-config@master] clienthints: Lower API max lag time to 5 minutes on group0 and 1

https://gerrit.wikimedia.org/r/951833

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:26:39Z] <hmonroy@deploy1002> Started scap: Backport for [[gerrit:951833|clienthints: Lower API max lag time to 5 minutes on group0 and 1 (T344797)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:28:10Z] <hmonroy@deploy1002> dreamyjazz and hmonroy: Backport for [[gerrit:951833|clienthints: Lower API max lag time to 5 minutes on group0 and 1 (T344797)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:33:48Z] <hmonroy@deploy1002> Finished scap: Backport for [[gerrit:951833|clienthints: Lower API max lag time to 5 minutes on group0 and 1 (T344797)]] (duration: 07m 09s)

Change 953315 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] clienthints: Raise maxlag for API back to default for group0 and 1

https://gerrit.wikimedia.org/r/953315

Change 953315 merged by jenkins-bot:

[operations/mediawiki-config@master] clienthints: Raise maxlag for API back to default for group0 and 1

https://gerrit.wikimedia.org/r/953315

Mentioned in SAL (#wikimedia-operations) [2023-08-29T20:09:03Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:953315|clienthints: Raise maxlag for API back to default for group0 and 1 (T344797)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-29T20:10:35Z] <urbanecm@deploy1002> urbanecm and dreamyjazz: Backport for [[gerrit:953315|clienthints: Raise maxlag for API back to default for group0 and 1 (T344797)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-29T20:16:17Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:953315|clienthints: Raise maxlag for API back to default for group0 and 1 (T344797)]] (duration: 07m 13s)

@Dreamy_Jazz anything else we want to do for this task? I think the existing config and limits look OK.

Agreed. I think this can be closed as declined because the config was not lowered.